public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <waiman.long@hpe.com>
To: Ling Ma <ling.ma.program@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	mingo@redhat.com, linux-kernel@vger.kernel.org,
	Ling <ling.ml@alibaba-inc.com>
Subject: Re: Improve spinlock performance by moving work to one core
Date: Mon, 30 Nov 2015 15:55:57 -0500	[thread overview]
Message-ID: <565CB7DD.6010003@hpe.com> (raw)
In-Reply-To: <CAOGi=dOoPbpVcJDU+Y1wtFenUiD0QRcxoKovq9wgb4zD+qs5Hw@mail.gmail.com>

On 11/30/2015 01:17 AM, Ling Ma wrote:
> Any comments, the patch is acceptable ?
>
> Thanks
> Ling
>
>
Ling,

The core idea of your current patch hasn't changed from your previous
patch.

My comment is that you should not attempt to sell it as a replacement
of the current spinlock mechanism. I just don't see that will happen
given the change in API semantics. Also, I think there are probably
cases that your patch cannot be applied. So treat it as a separate
synchronization mechanism that can be useful in some scenarios.

Cheers,
Longman


  reply	other threads:[~2015-11-30 20:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAOGi=dN6=iHUKyN=BcJ4dZkEyv5bA9amU1uCqD-hqaUJnY=Zug@mail.gmail.com>
2015-11-04 12:44 ` Improve spinlock performance by moving work to one core Ling Ma
     [not found] ` <563B8E85.6090104@hpe.com>
2015-11-06  4:28   ` Ling Ma
2015-11-06 17:38     ` Waiman Long
2015-11-23  9:41       ` Ling Ma
2015-11-25  1:56         ` Ling Ma
2015-11-25 19:05         ` Waiman Long
2015-11-26  3:49           ` Ling Ma
2015-11-26  9:00             ` Ling Ma
2015-11-30  6:17               ` Ling Ma
2015-11-30 20:55                 ` Waiman Long [this message]
2015-12-06 13:08                   ` Ling Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565CB7DD.6010003@hpe.com \
    --to=waiman.long@hpe.com \
    --cc=ling.ma.program@gmail.com \
    --cc=ling.ml@alibaba-inc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox