From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755410AbbLABX4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Nov 2015 20:23:56 -0500
Received: from mailout3.w1.samsung.com ([210.118.77.13]:12661 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751841AbbLABXy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Nov 2015 20:23:54 -0500
X-AuditID: cbfec7f4-f79026d00000418a-a0-565cf6a752a5
Subject: Re: [PATCH 04/10] ARM: s3c64xx: prepare initcalls for multiplatform
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
References: <1448467615-447097-1-git-send-email-arnd@arndb.de>
 <1448467615-447097-5-git-send-email-arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        Tomasz Figa <tfiga@chromium.org>,
        Ben Dooks <ben.dooks@codethink.co.uk>,
        linux-samsung-soc@vger.kernel.org
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <565CF6A4.1030608@samsung.com>
Date: Tue, 01 Dec 2015 10:23:48 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-version: 1.0
In-reply-to: <1448467615-447097-5-git-send-email-arnd@arndb.de>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4Fd3l32LCDD7fELRoPfaM0eLvpGPs
	Fg9utTJZTH34hM3i35Qb7BavXxha9D9+zWyx6fE1VovLu+awWcw4v4/J4nPrPzYHbo/fvyYx
	esxuuMji8ezlZCaPnbPusntsWtXJ5rF5Sb3Hy4m/2Tz6tqxi9Pi8SS6AM4rLJiU1J7MstUjf
	LoErY/fdD2wFazkrOm59Ym1g/MjWxcjJISFgIjFj51d2CFtM4sK99UBxLg4hgaWMEnef9bNA
	OE8ZJV49PcIMUiUs4CMx7/8psA4RAXeJddPnsXYxcgAVFUucmloGUs8ssIlJYuvG/2Ab2ASM
	JTYvXwJm8wpoSVw+9p8RxGYRUJX4uWkHC4gtKhAhMXFCAytEjaDEj8n3wOKcAvYSjddXM4HM
	ZxbQk7h/UQskzCwgL7F5zVvmCYwCs5B0zEKomoWkagEj8ypG0dTS5ILipPRcQ73ixNzi0rx0
	veT83E2MkHj5soNx8TGrQ4wCHIxKPLySa2PChFgTy4orcw8xSnAwK4nwqjwBCvGmJFZWpRbl
	xxeV5qQWH2KU5mBREuedu+t9iJBAemJJanZqakFqEUyWiYNTqoExzkTdSPigz+3J/xvOnj5S
	UWsnFmi1cXbAMrb01bdDhUPaJTw0OHiuXj6yXCv/Sk1ANAPnVJtptv/u9RuefLTjVGvB3rxr
	fIF3my3vW52an3y+r3Tbp2V+k422rlu0eMUPlbP8XEXbs1j32Bqa3/VR37g8UOCK4aRPu2e5
	7Gx//2pq2dXg2bufKbEUZyQaajEXFScCADO/TCyTAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 26.11.2015 01:06, Arnd Bergmann wrote:
> In a multiplatform kernel, each initcall is run regardless
> of the platform it is meant for, so it must not attempt to
> access SoC-specific registers.
> 
> This adds 'if (soc_is_s3c64xx)' to all initcalls that are
> specific to the s3c64xx platform, to prevent them from breaking
> other platforms once we can build them into a combined kernel.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/arm/mach-s3c64xx/common.c               |  4 ++--
>  arch/arm/mach-s3c64xx/cpuidle.c              |  5 ++++-
>  arch/arm/mach-s3c64xx/irq-pm.c               |  2 +-
>  arch/arm/mach-s3c64xx/mach-crag6410-module.c |  4 ++++
>  arch/arm/mach-s3c64xx/pl080.c                |  4 ++++
>  arch/arm/mach-s3c64xx/pm.c                   |  4 ++++
>  arch/arm/mach-s3c64xx/s3c6400.c              |  2 +-
>  arch/arm/mach-s3c64xx/s3c6410.c              |  2 +-
>  arch/arm/plat-samsung/gpio-samsung.c         | 11 +++++------
>  arch/arm/plat-samsung/init.c                 |  5 +++++
>  10 files changed, 31 insertions(+), 12 deletions(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof