public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Felipe Balbi <balbi@ti.com>, daniel@quora.org
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
	linux-kernel@vger.kernel.org
Subject: Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races.
Date: Tue, 01 Dec 2015 17:08:47 +0200	[thread overview]
Message-ID: <565DB7FF.2040903@linux.intel.com> (raw)
In-Reply-To: <87d1uq1bpz.fsf@saruman.tx.rr.com>

On 01.12.2015 16:32, Felipe Balbi wrote:
>
> Hi,
>
> Mathias Nyman <mathias.nyman@linux.intel.com> writes:
>> usb2 ports need to signal resume for 20ms before moving to U0 state.
>
> at least 20ms ;-) Recently, we decided to drive resume for 40ms to
> support devices with broken FW.
>

True, but specs talk about 20ms, and I'm just trying to give some context for what's
going on. This testpatch doesn't touch the timings.

Daniel is able to trigger a USB2 xhci resume issue which I hope is fixed with this patch.
This is especially made for his setup running a 4.3 kernel

If this works I'll clean up all the "20ms" in the commit message and comments.

Just noticed that xhci USB2 host initiated resume uses a hardcoded msleep(20).
That needs to be changed to USB_RESUME_TIMEOUT at some point.
For now I'm just interested in knowing if this patch works.

>
> this 'v2' note doesn't have to go into commit log, IMO.
>

It's going to be cleaned out as well, just there to explain to Daniel, and the world why
a second version of the testpatch was created.

-Mathias

  reply	other threads:[~2015-12-01 15:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAMVG2sus03xnbCSikFGG+t2fXM_gME_jMeGpGHxVuVRks07WCg@mail.gmail.com>
2015-11-30 15:16 ` [TESTPATCH] xhci: fix usb2 resume timing and races Mathias Nyman
2015-11-30 15:59   ` kbuild test robot
2015-12-01 15:47   ` Alan Stern
2015-12-02  8:50     ` Mathias Nyman
2015-12-01  8:26 ` [TESTPATCH v2] " Mathias Nyman
2015-12-01 14:32   ` Felipe Balbi
2015-12-01 15:08     ` Mathias Nyman [this message]
2015-12-01 15:11       ` Felipe Balbi
2015-12-05  4:02   ` Daniel J Blueman
2015-12-08 11:16     ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565DB7FF.2040903@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=daniel@quora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox