From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Nick Dyer <nick.dyer@itdev.co.uk>,
Yufeng Shen <miletus@chromium.org>,
Benson Leung <bleung@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: atmel_mxt_ts - add generic platform data for Chromebooks
Date: Tue, 1 Dec 2015 18:25:15 -0300 [thread overview]
Message-ID: <565E103B.6050103@osg.samsung.com> (raw)
In-Reply-To: <20151201212151.GC3740@dtor-ws>
Hello Dmitry,
On 12/01/2015 06:21 PM, Dmitry Torokhov wrote:
[snip]
>>>
>>> +static unsigned int chromebook_tp_buttons[] = {
>>
>> Maybe naming it chromebook_t19_buttons instead to make it clear that the
>> mapping is specific to the T19 object or at least document that assumption?
>
> The idea was to document that the mapping is applied to the touchpad
> and not any other Atmel device that might have T19 object in it, similar
> to samus_touchpad_buttons[] array.
>
You are right, the naming makes sense then indeed.
Thanks a lot for the explanation.
>>
>> Although is mentioned in the commit message so I don't have a strong
>> preference and the patch looks good to me:
>>
>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> Thank you for the review.
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
prev parent reply other threads:[~2015-12-01 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 18:58 [PATCH] Input: atmel_mxt_ts - add generic platform data for Chromebooks Dmitry Torokhov
2015-11-24 19:18 ` Javier Martinez Canillas
2015-12-01 21:21 ` Dmitry Torokhov
2015-12-01 21:25 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565E103B.6050103@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=nick.dyer@itdev.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox