From: Martyn Welch <martyn.welch@collabora.co.uk>
To: Jeremiah Mahler <jmmahler@gmail.com>,
Olof Johansson <olof@lixom.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Add support for monitoring Chrome OS firmware signals
Date: Wed, 02 Dec 2015 09:39:44 +0000 [thread overview]
Message-ID: <565EBC60.7020404@collabora.co.uk> (raw)
In-Reply-To: <20151202060846.GA3306@localhost.localdomain>
On 02/12/15 06:08, Jeremiah Mahler wrote:
> Martyn,
>
> On Tue, Dec 01, 2015 at 08:19:46PM +0000, Martyn Welch wrote:
>> Select Chromebooks have gpio attached to signals used to cause the firmware
>> to enter alternative modes of operation and/or control other device
> [...]
>> +
>> +static int chromeos_firmware_probe(struct platform_device *pdev)
>> +{
>> + int err;
>> + struct chromeos_firmware_data *gpios;
>> +
>> + gpios = devm_kmalloc(&pdev->dev, sizeof(gpios), GFP_KERNEL);
>
> Should this be 'sizeof(*gpios)' so it allocates enough room for the
> entire struct instead of just the pointer?
>
Yes, you're right, it should.
Martyn
next prev parent reply other threads:[~2015-12-02 9:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 19:12 Add support for Chrome OS firmware signals Martyn Welch
2015-12-01 19:12 ` [PATCH 1/3] Device tree binding documentation for chromeos-firmware Martyn Welch
2015-12-02 15:15 ` Rob Herring
2015-12-02 16:49 ` Martyn Welch
2015-12-02 18:44 ` Rob Herring
2015-12-02 21:47 ` Martyn Welch
2015-12-03 10:14 ` Martyn Welch
2015-12-03 15:08 ` Rob Herring
2015-12-03 16:11 ` Martyn Welch
2015-12-01 19:12 ` [PATCH 2/3] Add support for monitoring Chrome OS firmware signals Martyn Welch
2015-12-01 20:19 ` [PATCH v2] " Martyn Welch
2015-12-02 6:08 ` Jeremiah Mahler
2015-12-02 9:39 ` Martyn Welch [this message]
2015-12-02 10:07 ` [PATCH v3] " Martyn Welch
2015-12-01 19:12 ` [PATCH 3/3] Addition of binding for firmware signals on peach-pi Martyn Welch
2015-12-01 23:51 ` Krzysztof Kozlowski
2015-12-02 9:36 ` Martyn Welch
2015-12-03 0:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565EBC60.7020404@collabora.co.uk \
--to=martyn.welch@collabora.co.uk \
--cc=jmmahler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox