From: David Vrabel <david.vrabel@citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>, <xen-devel@lists.xenproject.org>
Cc: <linux-kernel@vger.kernel.org>, Bob Liu <bob.liu@oracle.com>,
Paul Durrant <paul.durrant@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jonathan Creekmore <jonathan.creekmore@gmail.com>
Subject: Re: [PATCH] xen-pciback: fix up cleanup path when alloc fails
Date: Wed, 2 Dec 2015 10:35:16 +0000 [thread overview]
Message-ID: <565EC964.3020006@citrix.com> (raw)
In-Reply-To: <1448569959-7245-1-git-send-email-cardoe@cardoe.com>
On 26/11/15 20:32, Doug Goldstein wrote:
> When allocating a pciback device fails, avoid the possibility of a
> use after free.
We should not require clearing drvdata for correctness. We should
ensure we retain drvdata for as long as it is needed.
I note that pcistub_device_release() has:
kfree(dev_data);
pci_set_drvdata(dev, NULL);
/* Clean-up the device */
xen_pcibk_config_free_dyn_fields(dev);
xen_pcibk_config_free_dev(dev);
Which should (at a minimum) be reordered to move the kfree(dev_data) to
after the calls that require it
David
next prev parent reply other threads:[~2015-12-02 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 20:32 [PATCH] xen-pciback: fix up cleanup path when alloc fails Doug Goldstein
2015-11-30 21:09 ` Boris Ostrovsky
[not found] ` <20151201164717.GA5032@char.us.oracle.com>
2015-12-01 19:24 ` Doug Goldstein
[not found] ` <20151201193517.GA32573@char.us.oracle.com>
2015-12-01 20:54 ` Doug Goldstein
2015-12-02 10:35 ` David Vrabel [this message]
2015-12-02 14:56 ` Doug Goldstein
2015-12-14 16:08 ` [Xen-devel] " David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565EC964.3020006@citrix.com \
--to=david.vrabel@citrix.com \
--cc=bob.liu@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=cardoe@cardoe.com \
--cc=jonathan.creekmore@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox