public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Wang <yun.wang@profitbricks.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak
Date: Wed, 2 Dec 2015 11:37:40 +0100	[thread overview]
Message-ID: <565EC9F4.2050401@profitbricks.com> (raw)
In-Reply-To: <5655D072.1000901@profitbricks.com>

Hi, Joerg

On 11/25/2015 04:14 PM, Michael Wang wrote:
> On 11/25/2015 04:08 PM, Joerg Roedel wrote:
[snip]
>>> This is caused by the 'irq_lookup_table' was allocated with
>>> __get_free_pages() which won't create kmemleak object, thus it's
>>> pointers won't be count as referencing 'irq_remap_table' in
>>> kmemleak scan.
>>
>> Isn't it better to allocate the kmemleak object manually instead of
>> ignoring all irq-table pointers? With this patch we might not notice any
>> real leak of irq-tables.
> 
> We've considered that too, but found that the irq-tables is not
> dynamically alloc/free, they won't be freed once initialized, so there
> is no leaking for such object :-)

Is there any more concern? actually we just want to get rid of this
annoying report on obj won't leak, if you're going to create obj for
'irq_lookup_table' that's also fine for us, or will you pick this patch?

Regards,
Michael Wang

> 
> Regards,
> Michael Wang
> 
>>
>>
>>
>> 	Joerg
>>

  reply	other threads:[~2015-12-02 10:37 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 11:09 [RFC PATCH] iommu/amd: make kmemleak ignore the 'irq_remap_table' object Michael Wang
2015-11-20 11:33 ` [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang
2015-11-20 12:31   ` Michael Wang
2015-11-25 11:14   ` Michael Wang
2015-11-25 15:08   ` Joerg Roedel
2015-11-25 15:14     ` Michael Wang
2015-12-02 10:37       ` Michael Wang [this message]
2015-12-02 10:52         ` Catalin Marinas
2015-12-02 10:56           ` Michael Wang
2015-12-02 11:31             ` Catalin Marinas
2015-12-02 11:38               ` Michael Wang
2015-12-02 11:51                 ` Joerg Roedel
2015-12-02 12:31                   ` Michael Wang
2015-12-02 12:53                     ` Borislav Petkov
2015-12-02 13:01                       ` Michael Wang
2015-12-02 13:13                         ` Borislav Petkov
2015-12-02 13:18                           ` Michael Wang
2015-12-02 13:40                             ` Borislav Petkov
2015-12-02 13:48                               ` Michael Wang
2015-12-02 13:59                                 ` Borislav Petkov
2015-12-02 14:09                                   ` Michael Wang
2015-12-02 14:13                                     ` Borislav Petkov
2015-12-02 14:21                                       ` Michael Wang
2015-12-02 17:36                                   ` Catalin Marinas
2015-12-02 18:40                                     ` Borislav Petkov
2015-12-03  8:47                                     ` Michael Wang
2015-12-02 12:56                     ` Joerg Roedel
2015-12-02 13:07                       ` Michael Wang
2015-12-02 11:17           ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565EC9F4.2050401@profitbricks.com \
    --to=yun.wang@profitbricks.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox