From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756586AbbLCGxk (ORCPT ); Thu, 3 Dec 2015 01:53:40 -0500 Received: from mx2.suse.de ([195.135.220.15]:55472 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755510AbbLCGxh (ORCPT ); Thu, 3 Dec 2015 01:53:37 -0500 Subject: Re: [PATCH v3] mm/compaction: __compact_pgdat() code cleanuup To: Joonsoo Kim , Andrew Morton References: <1449115845-19409-1-git-send-email-iamjoonsoo.kim@lge.com> Cc: Mel Gorman , Yaowei Bai , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Rientjes , Joonsoo Kim From: Vlastimil Babka Message-ID: <565FE6ED.5010505@suse.cz> Date: Thu, 3 Dec 2015 07:53:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1449115845-19409-1-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3.12.2015 5:10, Joonsoo Kim wrote: > This patch uses is_via_compact_memory() to distinguish compaction > from sysfs or sysctl. And, this patch also reduces indentation > on compaction_defer_reset() by filtering these cases first > before checking watermark. > > There is no functional change. > > Acked-by: Yaowei Bai > Acked-by: David Rientjes Acked-by: Vlastimil Babka > Signed-off-by: Joonsoo Kim > --- > mm/compaction.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index de3e1e7..01b1e5e 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1658,14 +1658,15 @@ static void __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc) > !compaction_deferred(zone, cc->order)) > compact_zone(zone, cc); > > - if (cc->order > 0) { > - if (zone_watermark_ok(zone, cc->order, > - low_wmark_pages(zone), 0, 0)) > - compaction_defer_reset(zone, cc->order, false); > - } > - > VM_BUG_ON(!list_empty(&cc->freepages)); > VM_BUG_ON(!list_empty(&cc->migratepages)); > + > + if (is_via_compact_memory(cc->order)) > + continue; > + > + if (zone_watermark_ok(zone, cc->order, > + low_wmark_pages(zone), 0, 0)) > + compaction_defer_reset(zone, cc->order, false); > } > } > >