From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755258AbbLDD0S (ORCPT ); Thu, 3 Dec 2015 22:26:18 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:14678 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbbLDD0R (ORCPT ); Thu, 3 Dec 2015 22:26:17 -0500 Subject: Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file To: Arnd Bergmann References: <1449110364-23464-1-git-send-email-xuejiancheng@huawei.com> <1615805.jmP28L2rmX@wuerfel> CC: , , , , , , , , , , , , , , , , , , From: xuejiancheng Message-ID: <566106B8.7080205@huawei.com> Date: Fri, 4 Dec 2015 11:21:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1615805.jmP28L2rmX@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.217.211] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.566106C5.002E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 9f3ebffdf0262d309131b86c7411f4a0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 2015/12/3 17:44, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: >> +#ifndef __DTS_HI3519_CLOCK_H >> +#define __DTS_HI3519_CLOCK_H > > Please try to avoid adding headers like this if you can at all. > > I might ask you to merge the header file in one merge window > otherwise and submit the platform code one kernel later, as they > tendn to cause us needless dependencies otherwise. > Sorry. In v1, Rob suggested putting binding doc and header files in a separate patch. The clock driver indeed depends on the header. I will put the header and the clock driver in a patch, and keep the binding doc in another patch. > >> +/* fixed rate */ >> +#define HI3519_FIXED_400M 1 >> +#define HI3519_FIXED_200M 2 >> +#define HI3519_FIXED_125M 3 >> +#define HI3519_FIXED_150M 4 >> +#define HI3519_FIXED_75M 5 >> +#define HI3519_FIXED_300M 6 >> +#define HI3519_FIXED_50M 7 >> +#define HI3519_FIXED_24M 8 >> +#define HI3519_FIXED_3M 9 >> + >> +/* mux clocks */ >> +#define HI3519_FMC_MUX 32 >> +#define HI3519_I2C_MUX 33 >> +#define HI3519_UART_MUX 34 >> +#define HI3519_SYSAXI_MUX 35 >> + >> +/*fixed factor clocks*/ >> +#define HI3519_SYSAPB_CLK 64 >> + >> +/* gate clocks */ >> +#define HI3519_FMC_CLK 129 >> +#define HI3519_UART0_CLK 153 >> +#define HI3519_UART1_CLK 154 >> +#define HI3519_UART2_CLK 155 >> +#define HI3519_UART3_CLK 156 >> +#define HI3519_UART4_CLK 157 > > Where do those numbers come from? They are not consecutive, so it sounds > like they are directly from the data sheet and won't be needed in the driver. > If that's true, just use the numbers directly, as you do for everything > else. The numbers are defined by myself, not directly from the data sheet. Some numbers are reserved for device nodes which will be added later. So they are not consecutive now. > >> +#define HI3519_NR_CLKS 256 >> +#define HI3519_NR_RSTS 256 >> > These seem to not be needed at all. These are used in drivers/clk/hisilicon/clk-hi3519.c. > > Arnd > > . >