From: "Christian König" <christian.koenig@amd.com>
To: Boszormenyi Zoltan <zboszor@pr.hu>, <cpaul@redhat.com>,
Alex Deucher <alexander.deucher@amd.com>,
David Airlie <airlied@linux.ie>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Cc: Jerome Glisse <jglisse@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH v2] drm/radeon: Retry DDC probing on DVI on failure if we got an HPD interrupt
Date: Fri, 4 Dec 2015 10:54:34 +0100 [thread overview]
Message-ID: <566162DA.40107@amd.com> (raw)
In-Reply-To: <56616029.1010007@pr.hu>
On 04.12.2015 10:43, Boszormenyi Zoltan wrote:
> 2015-12-04 09:53 keltezéssel, Christian König írta:
>> On 04.12.2015 00:26, cpaul@redhat.com wrote:
>>> From: Lyude <cpaul@redhat.com>
>>>
>>> HPD signals on DVI ports can be fired off before the pins required for
>>> DDC probing actually make contact, due to the pins for HPD making
>>> contact first. This results in a HPD signal being asserted but DDC
>>> probing failing, resulting in hotplugging occasionally failing.
>>>
>>> This is somewhat rare on most cards (depending on what angle you plug
>>> the DVI connector in), but on some cards it happens constantly. The
>>> Radeon R5 on the machine used for testing this patch for instance, runs
>>> into this issue just about every time I try to hotplug a DVI monitor and
>>> as a result hotplugging almost never works.
>>>
>>> Rescheduling the hotplug work for a second when we run into an HPD
>>> signal with a failing DDC probe usually gives enough time for the rest
>>> of the connector's pins to make contact, and fixes this issue.
>>>
>>> Signed-off-by: Lyude <cpaul@redhat.com>
>> I find a second a bit long, but if it works so what?
>>
>> Looks sane enough to me, patch is Reviewed-by: Christian König <christian.koenig@amd.com>
> Does this patch help in case of the Radeon chip only has HDMI and DP outputs
> exposed (Zotac ZBOXNANO-AQ01) but used with DVI or VGA monitors with
> converter cables? We have some problems with such scenarios that sounds
> eerily similar to this description.
No, at least active converter cables are a completely different case.
Regards,
Christian.
>
> Inquiry-by: Zoltán Böszörményi <zboszor@pr.hu>
> ;-)
>
> Thanks in advance.
>
next prev parent reply other threads:[~2015-12-04 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 15:52 [PATCH] drm/radeon: Retry DDC probing on DVI on failure if we got an HPD interrupt cpaul
2015-11-21 14:22 ` Christian König
2015-11-21 14:49 ` Daniel Stone
2015-11-21 15:22 ` Christian König
2015-11-23 2:44 ` Lyude
2015-11-23 14:20 ` Deucher, Alexander
2015-11-23 15:43 ` Lyude
2015-11-23 17:48 ` Lyude
2015-11-30 15:36 ` Lyude
2015-12-03 23:26 ` [PATCH v2] " cpaul
2015-12-04 8:53 ` Christian König
2015-12-04 9:43 ` Boszormenyi Zoltan
2015-12-04 9:54 ` Christian König [this message]
2015-12-04 18:09 ` Alex Deucher
2015-11-23 8:56 ` [PATCH] " Daniel Vetter
2015-11-23 8:55 ` Daniel Vetter
2015-12-03 14:58 ` Boszormenyi Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566162DA.40107@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=cpaul@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zboszor@pr.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox