From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, konrad.wilk@oracle.com,
akataria@vmware.com, fujita.tomonori@lab.ntt.co.jp,
revers@redhat.com, riel@redhat.com
Subject: Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory regions above MAX_DMA32_PFN
Date: Fri, 4 Dec 2015 13:37:04 +0100 [thread overview]
Message-ID: <566188F0.4010100@redhat.com> (raw)
In-Reply-To: <20151204133310.04938fb5@nial.brq.redhat.com>
On 04/12/2015 13:33, Igor Mammedov wrote:
> That doesn't pass strict type check:
>
> include/linux/kernel.h:730:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> (void) (&_max1 == &_max2); \
> ^
> arch/x86/mm/srat.c:206:21: note: in expansion of macro ‘max’
> max_possible_pfn = max(max_possible_pfn, PFN_UP(end - 1));
>
> I can change max_possible_pfn to u64 to match PFN_UP(end - 1) type.
Sounds like a good idea anyway.
Paolo
next prev parent reply other threads:[~2015-12-04 12:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 11:25 [PATCH v2 0/2] x86: enable SWIOTLB if system has SRAT memory regions above MAX_DMA32_PFN Igor Mammedov
2015-12-04 11:25 ` [PATCH v2 1/2] x86: introduce max_possible_pfn Igor Mammedov
2015-12-04 11:25 ` [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory regions above MAX_DMA32_PFN Igor Mammedov
2015-12-04 11:49 ` Ingo Molnar
2015-12-04 12:16 ` Igor Mammedov
2015-12-04 12:33 ` Igor Mammedov
2015-12-04 12:37 ` Paolo Bonzini [this message]
2015-12-04 14:34 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566188F0.4010100@redhat.com \
--to=pbonzini@redhat.com \
--cc=akataria@vmware.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=revers@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox