From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbbLDRdn (ORCPT ); Fri, 4 Dec 2015 12:33:43 -0500 Received: from foss.arm.com ([217.140.101.70]:55918 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbbLDRdl (ORCPT ); Fri, 4 Dec 2015 12:33:41 -0500 Subject: Re: [PATCH] ARM: at91: fix pinctrl driver selection To: Alexandre Belloni , Nicolas Ferre References: <1449249513-22972-1-git-send-email-alexandre.belloni@free-electrons.com> Cc: Sudeep Holla , Ludovic Desroches , Jean-Christophe Plagniol-Villard , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Sudeep Holla Organization: ARM Message-ID: <5661CE71.5050206@arm.com> Date: Fri, 4 Dec 2015 17:33:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449249513-22972-1-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/12/15 17:18, Alexandre Belloni wrote: > From: Ludovic Desroches > > Move the selection of the pinctrl driver to SoC family level since we > have two pinctrl drivers. It is useless to select one which is not > compatible with the SoC. > > [abelloni: fixed pm.c when only sama2d2 is selected] > Signed-off-by: Ludovic Desroches > Acked-by: Nicolas Ferre > Signed-off-by: Alexandre Belloni > --- > arch/arm/mach-at91/Kconfig | 6 +++++- > arch/arm/mach-at91/pm.c | 7 ++++++- > 2 files changed, 11 insertions(+), 2 deletions(-) > [...] > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > index 80e277cfcc8b..01cbb17e6f6b 100644 > --- a/arch/arm/mach-at91/pm.c > +++ b/arch/arm/mach-at91/pm.c > @@ -41,8 +41,10 @@ > * implementation should be moved down into the pinctrl driver and get > * called as part of the generic suspend/resume path. > */ > +#ifdef PINCTRL_AT91 Accidentally glanced at this patch when my mail client got hung at this patch :), I think you mean CONFIG_PINCTRL_AT91 here and later below. -- Regards, Sudeep