public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <info@lategoodbye.de>
To: Remi Pommarel <repk@triplefau.lt>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Eric Anholt <eric@anholt.net>, Lee Jones <lee@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree
Date: Sun, 6 Dec 2015 22:16:25 +0100	[thread overview]
Message-ID: <5664A5A9.4030204@lategoodbye.de> (raw)
In-Reply-To: <1449418969-5565-5-git-send-email-repk@triplefau.lt>

Hi Remi,

please send this patch to devicetree@vger.kernel.org.

Am 06.12.2015 um 17:22 schrieb Remi Pommarel:
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> ---
>   arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 ++++
>   arch/arm/boot/dts/bcm2835.dtsi     | 9 +++++++++
>   2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> index 3572f03..55801e0 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> @@ -60,3 +60,7 @@
>   	status = "okay";
>   	bus-width = <4>;
>   };
> +
> +&pwm {
> +	status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> index aef64de..641f7f4 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -149,6 +149,15 @@
>   			status = "disabled";
>   		};
>
> +		pwm: pwm@7e20c000 {
> +			compatible = "brcm,bcm2835-pwm";
> +			reg = <0x7e20c000 0x28>;
> +			clocks = <&clocks BCM2835_CLOCK_PWM>;

Looks like #pwm-cells is missing.

Regards
Stefan

> +			assigned-clocks = <&clocks BCM2835_CLOCK_PWM>;
> +			assigned-clock-rates = <10000000>;
> +			status = "disabled";
> +		};
> +
>   		sdhci: sdhci@7e300000 {
>   			compatible = "brcm,bcm2835-sdhci";
>   			reg = <0x7e300000 0x100>;
>


  reply	other threads:[~2015-12-06 21:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 16:22 [PATCH v3 0/4] Add PWM clock support for bcm2835 Remi Pommarel
2015-12-06 16:22 ` [PATCH v3 1/4] clk: bcm2835: add a round up ability to the clock divisor Remi Pommarel
2015-12-08  1:28   ` Eric Anholt
2016-01-10 16:27   ` Martin Sperl
2015-12-06 16:22 ` [PATCH v3 2/4] clk: bcm2835: Support for clock parent selection Remi Pommarel
2015-12-08  1:32   ` Eric Anholt
2015-12-06 16:22 ` [PATCH v3 3/4] clk: bcm2835: Add PWM clock support Remi Pommarel
2015-12-06 16:22 ` [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree Remi Pommarel
2015-12-06 21:16   ` Stefan Wahren [this message]
2015-12-07 18:17     ` Remi Pommarel
2015-12-07 18:42       ` Stefan Wahren
2015-12-08  4:09         ` Eric Anholt
2015-12-16  7:57           ` Remi Pommarel
2015-12-16 20:05             ` Eric Anholt
2015-12-23 18:57 ` [PATCH v3 0/4] Add PWM clock support for bcm2835 Remi Pommarel
2015-12-25  5:06   ` Michael Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5664A5A9.4030204@lategoodbye.de \
    --to=info@lategoodbye.de \
    --cc=eric@anholt.net \
    --cc=lee@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=repk@triplefau.lt \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox