From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755075AbbLGCMu (ORCPT ); Sun, 6 Dec 2015 21:12:50 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:55516 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754191AbbLGCMs (ORCPT ); Sun, 6 Dec 2015 21:12:48 -0500 X-AuditID: cbfec7f5-f79b16d000005389-a3-5664eb1dc413 Subject: Re: [PATCH 1/2] power: Fix unmet dependency on POWER_SUPPLY by POWER_RESET by uncoupling them To: Sebastian Reichel References: <1449035947-16758-1-git-send-email-k.kozlowski@samsung.com> <20151205005937.GF22936@earth> Cc: Dmitry Eremin-Solenikov , David Woodhouse , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Pavel Fedin , Arnd Bergmann , Olof Johansson From: Krzysztof Kozlowski Message-id: <5664EB17.5000309@samsung.com> Date: Mon, 07 Dec 2015 11:12:39 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <20151205005937.GF22936@earth> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsVy+t/xy7qyr1PCDD6sErT4O+kYu8WkJ++Z LSaunMxs0bx4PZvF6xeGFpd3zWGz+Nx7hNFixvl9TBanrn9ms3h1aRWbxendJQ7cHr9/TWL0 2DnrLrvH5hVaHptWdbJ57J+7ht3jyokmVo++LasYPT5vkgvgiOKySUnNySxLLdK3S+DKmDdt O2PBR46KL9tmsTUwbmTvYuTkkBAwkfiy4gsLhC0mceHeerYuRi4OIYGljBLzl+9ignB+MUpM e3+RGaRKWCBD4teus2wgtoiAmsT7S0/BuoWA4tffPADrZha4xCRxeWsPE0iCTcBYYvPyJWAN vAJaEq8W3weLswioSmw/9x1oKAeHqECExKIdmRAlghI/Jt8Dm8kpoC3x7d4xVpASZgE9ifsX tUDCzALyEpvXvGWewCgwC0nHLISqWUiqFjAyr2IUTS1NLihOSs810itOzC0uzUvXS87P3cQI iZGvOxiXHrM6xCjAwajEwzshMyVMiDWxrLgy9xCjBAezkgivcBxQiDclsbIqtSg/vqg0J7X4 EKM0B4uSOO/MXe9DhATSE0tSs1NTC1KLYLJMHJxSDYzart+ZD9b+vuu9aatGg6DJ3aDtvBsk 8gN1bDjnlf4qbzA5/Pz+nRRVT5Vngl1WKyVKk8KKHqicNsiazP71qtrOpwyO++X+bQvJ4BHM CPIrmH4o9IyDaXnqUkE+x3rhW3IckXGquq9+7G645Wfa/PVymekEl+KL91nXvGsN3GwXvmzy DkfjD0osxRmJhlrMRcWJAPrBX12NAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.12.2015 09:59, Sebastian Reichel wrote: > Hi, > > On Wed, Dec 02, 2015 at 02:59:06PM +0900, Krzysztof Kozlowski wrote: >> Actually reset/power off handlers do not really depend on power supply. >> Move the power reset out of power supply block so it will appear in main >> drivers section. This fixes following build warning (encountered on ARM >> exynos defconfig when POWER_SUPPLY is disabled manually): >> >> warning: (ARCH_HISI && ARCH_INTEGRATOR && ARCH_EXYNOS && ARCH_VEXPRESS && REALVIEW_DT) selects POWER_RESET which has unmet direct dependencies (POWER_SUPPLY) >> warning: (ARCH_EXYNOS) selects POWER_RESET_SYSCON which has unmet direct dependencies (POWER_SUPPLY && POWER_RESET && OF) >> warning: (ARCH_EXYNOS) selects POWER_RESET_SYSCON_POWEROFF which has unmet direct dependencies (POWER_SUPPLY && POWER_RESET && OF) > > nice catch. I don't really like the Makefile changes, though. I think > it would be better to make the power/ entry in drivers/Makefile into > "obj-y" and handle the details in drivers/power/Makefile. You idea indeed looks better, I'll send a v2. Best regards, Krzysztof