From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965027AbbLGXiY (ORCPT ); Mon, 7 Dec 2015 18:38:24 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:35905 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965003AbbLGXiV (ORCPT ); Mon, 7 Dec 2015 18:38:21 -0500 Subject: Re: [PATCH v5 06/11] spi: imx: return error from dma channel request To: Sascha Hauer References: <1449334629-4715-1-git-send-email-anton.bondarenko.sama@gmail.com> <1449334629-4715-7-git-send-email-anton.bondarenko.sama@gmail.com> <20151207093236.GB11966@pengutronix.de> Cc: broonie@kernel.org, b38343@freescale.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vladimir_zapolskiy@mentor.com, jiada_wang@mentor.com From: Anton Bondarenko Message-ID: <56661869.5090503@gmail.com> Date: Tue, 8 Dec 2015 00:38:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151207093236.GB11966@pengutronix.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-12-07 10:32, Sascha Hauer wrote: > On Sat, Dec 05, 2015 at 05:57:04PM +0100, Anton Bondarenko wrote: >> On SDMA initialization return exactly the same error, which is >> reported by dma_request_slave_channel_reason(), it is a preceding >> change to defer SPI DMA initialization, if SDMA module is not yet >> available. >> >> Signed-off-by: Vladimir Zapolskiy >> Signed-off-by: Anton Bondarenko >> --- >> drivers/spi/spi-imx.c | 27 ++++++++++++++++----------- >> 1 file changed, 16 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c >> index 3525616..277dd75 100644 >> --- a/drivers/spi/spi-imx.c >> +++ b/drivers/spi/spi-imx.c >> @@ -846,10 +846,11 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, >> spi_imx->wml = spi_imx_get_fifosize(spi_imx) / 2; >> >> /* Prepare for TX DMA: */ >> - master->dma_tx = dma_request_slave_channel(dev, "tx"); >> - if (!master->dma_tx) { >> - dev_err(dev, "cannot get the TX DMA channel!\n"); >> - ret = -EINVAL; >> + master->dma_tx = dma_request_slave_channel_reason(dev, "tx"); >> + if (IS_ERR(master->dma_tx)) { >> + dev_info(dev, "cannot get the TX DMA channel!\n"); > > When changing it can you add the error code to the message? That's > usually the next thing one wants to know when reading it. Also, isn't > dev_dbg enough here? Otherwise the driver gets really verbose when it > actually defers probe. > > Sascha > Agreed. But the error from spi_imx_sdma_init printed in probe. Anyway, I've changed the code as requested in upcoming series V6. Regards, Anton