[PATCH] mips: mm: fix build failure

[PATCH] mips: mm: fix build failure

[Sudip Mukherjee]

We are having build failure with mips defconfig with the error:
"MADV_FREE" redefined.

commit d53d95838c7d introduced uniform values for all architecture but
missed removing the old value.

Fixes: d53d95838c7d ("arch/*/include/uapi/asm/mman.h: : let MADV_FREE have same value for all architectures")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/95309512

 arch/mips/include/uapi/asm/mman.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/include/uapi/asm/mman.h b/arch/mips/include/uapi/asm/mman.h
index b0ebe59..ccdcfcb 100644
--- a/arch/mips/include/uapi/asm/mman.h
+++ b/arch/mips/include/uapi/asm/mman.h
@@ -73,7 +73,6 @@
 #define MADV_SEQUENTIAL 2		/* expect sequential page references */
 #define MADV_WILLNEED	3		/* will need these pages */
 #define MADV_DONTNEED	4		/* don't need these pages */
-#define MADV_FREE	5		/* free pages only if memory pressure */
 
 /* common parameters: try to keep these consistent across architectures */
 #define MADV_FREE	8		/* free pages only if memory pressure */
-- 
1.9.1

Re: [PATCH] mips: mm: fix build failure

[Chen Gang]

On 12/7/15 20:09, Sudip Mukherjee wrote:
> We are having build failure with mips defconfig with the error:
> "MADV_FREE" redefined.
> 
> commit d53d95838c7d introduced uniform values for all architecture but
> missed removing the old value.
> 

What you said is OK to me. For me, one fix patch for all related archs
is enough (need not send several patches for each arch). :-)


Thanks.

> Fixes: d53d95838c7d ("arch/*/include/uapi/asm/mman.h: : let MADV_FREE have same value for all architectures")
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> 
> build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/95309512
> 
>  arch/mips/include/uapi/asm/mman.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/uapi/asm/mman.h b/arch/mips/include/uapi/asm/mman.h
> index b0ebe59..ccdcfcb 100644
> --- a/arch/mips/include/uapi/asm/mman.h
> +++ b/arch/mips/include/uapi/asm/mman.h
> @@ -73,7 +73,6 @@
>  #define MADV_SEQUENTIAL 2		/* expect sequential page references */
>  #define MADV_WILLNEED	3		/* will need these pages */
>  #define MADV_DONTNEED	4		/* don't need these pages */
> -#define MADV_FREE	5		/* free pages only if memory pressure */
>  
>  /* common parameters: try to keep these consistent across architectures */
>  #define MADV_FREE	8		/* free pages only if memory pressure */
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] mips: mm: fix build failure

[Sudip Mukherjee]

On Tue, Dec 08, 2015 at 09:01:07PM +0800, Chen Gang wrote:
> On 12/7/15 20:09, Sudip Mukherjee wrote:
> > We are having build failure with mips defconfig with the error:
> > "MADV_FREE" redefined.
> > 
> > commit d53d95838c7d introduced uniform values for all architecture but
> > missed removing the old value.
> > 
> 
> What you said is OK to me. For me, one fix patch for all related archs
> is enough (need not send several patches for each arch). :-)

Ok, I thought it will be different tree and different maintainer, so
sent separate patch.
Sending a combined patch now.

regards
sudip