From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756239AbbLHNEZ (ORCPT ); Tue, 8 Dec 2015 08:04:25 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34854 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbbLHNEY (ORCPT ); Tue, 8 Dec 2015 08:04:24 -0500 X-Greylist: delayed 364 seconds by postgrey-1.27 at vger.kernel.org; Tue, 08 Dec 2015 08:04:24 EST Message-ID: <5666D493.1030604@gmail.com> Date: Tue, 08 Dec 2015 21:01:07 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sudip Mukherjee , Ralf Baechle , Andrew Morton CC: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Minchan Kim Subject: Re: [PATCH] mips: mm: fix build failure References: <1449490164-21029-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1449490164-21029-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/15 20:09, Sudip Mukherjee wrote: > We are having build failure with mips defconfig with the error: > "MADV_FREE" redefined. > > commit d53d95838c7d introduced uniform values for all architecture but > missed removing the old value. > What you said is OK to me. For me, one fix patch for all related archs is enough (need not send several patches for each arch). :-) Thanks. > Fixes: d53d95838c7d ("arch/*/include/uapi/asm/mman.h: : let MADV_FREE have same value for all architectures") > Signed-off-by: Sudip Mukherjee > --- > > build log is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/95309512 > > arch/mips/include/uapi/asm/mman.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/mips/include/uapi/asm/mman.h b/arch/mips/include/uapi/asm/mman.h > index b0ebe59..ccdcfcb 100644 > --- a/arch/mips/include/uapi/asm/mman.h > +++ b/arch/mips/include/uapi/asm/mman.h > @@ -73,7 +73,6 @@ > #define MADV_SEQUENTIAL 2 /* expect sequential page references */ > #define MADV_WILLNEED 3 /* will need these pages */ > #define MADV_DONTNEED 4 /* don't need these pages */ > -#define MADV_FREE 5 /* free pages only if memory pressure */ > > /* common parameters: try to keep these consistent across architectures */ > #define MADV_FREE 8 /* free pages only if memory pressure */ > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed