Re: [alsa-devel] [PATCH 0/2] Add support for Pistachio internal DAC

Re: [alsa-devel] [PATCH 0/2] Add support for Pistachio internal DAC

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

On Mon, Nov 23, 2015 at 05:24:57PM +0000, Damien Horsley wrote:
> From: "Damien.Horsley" <Damien.Horsley@imgtec.com>
> 
> Add binding document and driver for Pistachio internal DAC

Please don't add noise like [alsa-devel] to the subject line of mails,
it just consumes space in the subject line which makes it harder to see
what's going on when scanning your inbox (I know that the list does it
for copies that goes to the list).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:

> +	/* The mute state as set by alsa using the digital_mute callback */
> +	bool alsa_mute_state;
> +	/* The mute state as set by the userspace mute control */
> +	bool control_mute_state;
> +	/* The actual mute state is equal to an OR of the above */

Does the device *need* the digital mute to avoid noise?  If there's no
strong need for it then just don't bother which simplifies the code a
lot.

Otherwise this looks good.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC

[Damien Horsley]

On 25/11/15 12:47, Mark Brown wrote:
> On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:
> 
>> +	/* The mute state as set by alsa using the digital_mute callback */
>> +	bool alsa_mute_state;
>> +	/* The mute state as set by the userspace mute control */
>> +	bool control_mute_state;
>> +	/* The actual mute state is equal to an OR of the above */
> 
> Does the device *need* the digital mute to avoid noise?  If there's no
> strong need for it then just don't bother which simplifies the code a
> lot.
> 
> Otherwise this looks good.
> 

It does not seem to make a difference. I will remove and repost.