From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753521AbbLICTs (ORCPT ); Tue, 8 Dec 2015 21:19:48 -0500 Received: from lists.s-osg.org ([54.187.51.154]:49040 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753488AbbLICTn (ORCPT ); Tue, 8 Dec 2015 21:19:43 -0500 Subject: Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables To: Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Thomas Abraham , Sylwester Nawrocki , Mike Turquette , Kukjin Kim , Kukjin Kim , Viresh Kumar , Ben Gamari References: <1449512300-17230-1-git-send-email-b.zolnierkie@samsung.com> <1449512300-17230-8-git-send-email-b.zolnierkie@samsung.com> <56669126.7050803@samsung.com> <5666DE25.7090708@osg.samsung.com> <56677701.10809@samsung.com> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <56678FB2.1080205@osg.samsung.com> Date: Tue, 8 Dec 2015 23:19:30 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56677701.10809@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 12/08/2015 09:34 PM, Krzysztof Kozlowski wrote: > On 08.12.2015 22:41, Javier Martinez Canillas wrote: >> On 12/08/2015 05:13 AM, Krzysztof Kozlowski wrote: >>> >>> This looks like a very-non-atomic way of handling a change. You added >>> opp tables to exynos5420 before so at that time they will be applied to >>> Odroid XU3 family which uses different CPU order. After that you are >>> fixing the tables to proper CPU order. Direct bisectability probably >>> won't be an issue because all of DTS would go to separate branch... but >>> the logic behind confuses. >>> >> >> Agreed. >> >>> I think this should be squashed into 3/8. >>> >> >> I think the patch should be split in two changes, the CPUs device nodes >> having the wrong clock for clusters is a bug and has to be fixed in a >> patch before adding the OPP tables and the OPP tables changes should be >> separated and merged with patch 3/8 as you suggest. > > I don't get the point about wrong clock (bug). Where is the bug? Beside > of course what was introduced in 3/8 and it is not valid for reversed > cluster order. > You are absolutely correct, for some reason I thought that the CLK_ARM_CLK and CLK_KFC_CLK clocks were already defined in the cpu0 and cpu4 nodes from exynos5420.dtsi and commit df09df6f9ac3 ("ARM: dts: add exynos5422-cpus.dtsi to correct cpu order") missed that when reversing the cores for Exynos5422. But on a second look to patch 3/8, I see that the clocks are defined in that patch so I agree that $SUBJECT should just be squashed with 3/8 without doing any split. Sorry for the noise. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America