From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753378AbbLIIoj (ORCPT ); Wed, 9 Dec 2015 03:44:39 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:11949 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbbLIIog (ORCPT ); Wed, 9 Dec 2015 03:44:36 -0500 Subject: Re: [GIT PULL] UML fixes for 4.4-rc5 To: Linus Torvalds , Ingo Molnar References: <56674E18.7020905@nod.at> Cc: "linux-kernel@vger.kernel.org" , user-mode-linux-devel , the arch/x86 maintainers From: Richard Weinberger X-Enigmail-Draft-Status: N1110 Message-ID: <5667E9F0.9070102@nod.at> Date: Wed, 9 Dec 2015 09:44:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus, Am 09.12.2015 um 02:35 schrieb Linus Torvalds: > On Tue, Dec 8, 2015 at 1:39 PM, Richard Weinberger wrote: >> >> This pull request contains various bug fixes, most of them are >> fall out from the merge window. >> >> Richard Weinberger (2): >> um: Fix fpstate handling > > Ugh. This is very ugly. It's apparently the result of commit > 530e5c827182 ("x86/headers: Make sigcontext pointers bit independent") > and apparently nobody noticed the uml fallout. > > I've pulled, but I wanted the x86 people involved to be aware of this > ugly corner. I wonder if there might be some way for uml to continue > to use that fpstate entry as a pointer, at least when the wordsize > matches (which it will)? I agree. One way to get rid of the ugliness would be rewriting UML's FP code. The code is very old and doing it like x86 does would be a good thing anyway. But that's nothing I'll do at this stage of development. That's material for the next merge window. Thanks, //richard