From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751381AbbLIPJO (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 10:09:14 -0500
Received: from foss.arm.com ([217.140.101.70]:50121 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750790AbbLIPJN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 10:09:13 -0500
Message-ID: <56684415.40806@arm.com>
Date: Wed, 09 Dec 2015 15:09:09 +0000
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: Andre Przywara <andre.przywara@arm.com>, robh+dt@kernel.org,
        pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk
CC: catalin.marinas@arm.com, will.deacon@arm.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        galak@codeaurora.org, drjones@redhat.com
Subject: Re: [PATCH 2/4] arm64: dts: Foundation model: increate GICC region
 to allow EOImode=1
References: <1444729069-27922-1-git-send-email-andre.przywara@arm.com> <1444729069-27922-3-git-send-email-andre.przywara@arm.com>
In-Reply-To: <1444729069-27922-3-git-send-email-andre.przywara@arm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hey Andre,

On 13/10/15 10:37, Andre Przywara wrote:
> Recent commits made the GIC driver use EOImode=1 for all GICs
> that advertise the proper GICC region size.
> To let the model benefit from the blessings of that mode, increase
> the GICC region to its actual size of 8K.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>

The patch looks good, but the commit log is slightly confusing. Apart
from the typo in the title ("increate"), it would be better to say
something like:

"The Foundation model GIC mapping is wrong, as the GICC region should be
8kB instead of 4kB (the model implements the GICv2 architecture). This
defect prevents the driver from switching to EOImode==1."

Or something similar.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...