From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545AbbLJAo0 (ORCPT ); Wed, 9 Dec 2015 19:44:26 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:23618 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbbLJAoY (ORCPT ); Wed, 9 Dec 2015 19:44:24 -0500 X-AuditID: cbfec7f5-f79b16d000005389-85-5668cae48bd8 Subject: Re: [PATCH v2 03/19] ARM: dts: Add DMC bus node for Exynos3250 To: Chanwoo Choi , myungjoo.ham@samsung.com, kgene@kernel.org References: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> <1449634091-1842-4-git-send-email-cw00.choi@samsung.com> Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5668CADE.8090706@samsung.com> Date: Thu, 10 Dec 2015 09:44:14 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1449634091-1842-4-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsVy+t/xy7pPTmWEGdx5amFx/ctzVov5R86x WvS/Wchqce7VSkaL1y8MLfofv2a2ONv0ht3i8q45bBafe48wWsw4v4/JYt3GW+wWty/zWiy9 fpHJ4nbjCjaLCdPXsli07j3CbtG2+gOrg6DHmnlrGD1amnvYPC739TJ57Jx1l91j5fIvbB6b VnWyefw7xu7Rt2UVo8fnTXIBnFFcNimpOZllqUX6dglcGVsWLmEruM5f8e6JVgPjO+4uRk4O CQETib83XrJD2GISF+6tZ+ti5OIQEljKKNE54wIrhPOUUeJB7y9WkCphAXeJY7+OM4HYIgJh ErNn/GDuYuQAKqqXWH1VDqSeWeAuk8TF90/YQGrYBIwlNi9fAmbzCmhJXN35AqyXRUBVYuWi 0+wgvaICERKLdmRClAhK/Jh8jwXE5hRwlTjfd4gRpIRZQE/i/kUtkDCzgLzE5jVvmScwCsxC 0jELoWoWkqoFjMyrGEVTS5MLipPSc430ihNzi0vz0vWS83M3MUKi7OsOxqXHrA4xCnAwKvHw VjilhwmxJpYVV+YeYpTgYFYS4fU5mREmxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfmrvchQgLp iSWp2ampBalFMFkmDk6pBkYhXYG2siledhsv9ty62q+3SJvTS2TL3wI3ta8fN6nbbz3zYJU1 u7bcnz3VnoUGoqa5nw5anl5Q42m+nrvnyoEoh01y+3yvSaf3qRsYrnC4+/nov+k++/KeqjJf OyJ6OXVzIm+24ZRpetV1WwQOaz28yBxjwnZw3p6ZdcmHf/n/l21wKRWZVK7EUpyRaKjFXFSc CAAGiHn8rgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.12.2015 13:07, Chanwoo Choi wrote: > This patch adds the DMC (Dynamic Memory Controller) bus node for Exynos3250 SoC. > The DMC is an AMBA AXI-compliant slave to interface external JEDEC standard > SDRAM devices. The bus includes the OPP tables and the source clock for DMC > block. > > Following list specifies the detailed relation between the clock and DMC block: > - The source clock of DMC block : div_dmc > > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos3250.dtsi | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 2f30d632f1cc..7214c5e42150 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -687,6 +687,40 @@ > clock-names = "ppmu"; > status = "disabled"; > }; > + > + bus_dmc: bus_dmc { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu_dmc CLK_DIV_DMC>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_dmc_opp_table>; > + status = "disabled"; > + }; > + > + bus_dmc_opp_table: opp_table1 { This is the firsy opp_table, right? So: s/opp_table1/opp_table0/ > + compatible = "operating-points-v2"; > + opp-shared; > + > + opp00 { > + opp-hz = /bits/ 64 <50000000>; > + opp-microvolt = <800000>; > + }; > + opp01 { > + opp-hz = /bits/ 64 <100000000>; > + opp-microvolt = <800000>; > + }; > + opp02 { > + opp-hz = /bits/ 64 <134000000>; > + opp-microvolt = <800000>; Why 134, not 133 MHz? > + }; > + opp03 { > + opp-hz = /bits/ 64 <200000000>; > + opp-microvolt = <800000>; Shouldn't this be 825 mV, not 800? I think we used previously that value for our devices. Best regards, Krzysztof > + }; > + opp04 { > + opp-hz = /bits/ 64 <400000000>; > + opp-microvolt = <875000>; > + }; > + }; > }; > }; > >