From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbbLJBgx (ORCPT ); Wed, 9 Dec 2015 20:36:53 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:33482 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbbLJBgv (ORCPT ); Wed, 9 Dec 2015 20:36:51 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee691-f79766d0000012b6-6c-5668d730dc5b Content-transfer-encoding: 8BIT Message-id: <5668D730.6070404@samsung.com> Date: Thu, 10 Dec 2015 10:36:48 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 09/19] PM / devfreq: exynos: Update documentation for bus devices using passive governor References: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> <1449634091-1842-10-git-send-email-cw00.choi@samsung.com> <5668D5DD.5090202@samsung.com> In-reply-to: <5668D5DD.5090202@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsWyRsSkUNfwekaYwdZ7zBbzj5xjteh/s5DV 4tyrlYwWr18YWvQ/fs1scbbpDbvF5V1z2Cw+9x5htJhxfh+TxbqNt9gtbl/mtVh6/SKTxe3G FWwWE6avZbFo3XuE3aJt9QdWBwGPNfPWMHq0NPeweVzu62Xy2DnrLrvHyuVf2Dw2repk8/h3 jN2jb8sqRo/Pm+QCOKO4bFJSczLLUov07RK4Mq5tvM5a8Ea/YmP3KeYGxj8qXYycHBICJhLr dk9gg7DFJC7cWw9kc3EICaxglJiy6BkbTNGBT+fZIRKzGCWm9l5mBEnwCghK/Jh8j6WLkYOD WUBe4silbJAws4C6xKR5i5gh6h8wSjQtWcEKUa8lcWLHbBYQm0VAVWLrzz1MIDYbUHz/ixts IHNEBSIkuk9UgoRFBOIlNr24CnYQs8BdJomL75+A1QgLFEq8+6IKMX8ho8SWe4/BDuUU0Ja4 8GY5WIOEwBYOif7Tq9gglglIfJt8COxQCQFZiU0HmCEek5Q4uOIGywRGsVlI3pmF8M4sJO8s YGRexSiaWpBcUJyUXmSqV5yYW1yal66XnJ+7iREY8af/PZu4g/H+AetDjAIcjEo8vBdc0sOE WBPLiitzDzGaAh0xkVlKNDkfmFbySuINjc2MLExNTI2NzC3NlMR5daR/BgsJpCeWpGanphak FsUXleakFh9iZOLglGpgXGQWJ90+7/K+hrIr5lonv2urxH3adV3Fy/HIE5N7M7PeS17mdDIo UP17/eSFKcHPivN9LcSWG1RO2/ni7XEWoz3X3P19jJPUH57W+dh5uJqBmS33xB/BPp006ziD Yr6z+7xYkjflJnt5XXs6XaU6sWtz3d8OFddU8S+SE8XEm7JN3zOYdrgosRRnJBpqMRcVJwIA 848r+fMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLKsWRmVeSWpSXmKPExsVy+t9jQV2D6xlhBps7rCzmHznHatH/ZiGr xblXKxktXr8wtOh//JrZ4mzTG3aLy7vmsFl87j3CaDHj/D4mi3Ubb7Fb3L7Ma7H0+kUmi9uN K9gsJkxfy2LRuvcIu0Xb6g+sDgIea+atYfRoae5h87jc18vksXPWXXaPlcu/sHlsWtXJ5vHv GLtH35ZVjB6fN8kFcEY1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam 2iq5+AToumXmAH2hpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcy4tvE6 a8Eb/YqN3aeYGxj/qHQxcnJICJhIHPh0nh3CFpO4cG89WxcjF4eQwCxGiam9lxlBErwCghI/ Jt9j6WLk4GAWkJc4cikbJMwsoC4xad4iZoj6B4wSTUtWsELUa0mc2DGbBcRmEVCV2PpzDxOI zQYU3//iBhvIHFGBCInuE5UgYRGBeIlNL66C7WUWuMskcfH9E7AaYYFCiXdfVCHmL2SU2HLv MRtIA6eAtsSFN8vZJjACXYlw3iyE82YhOW8BI/MqRonUguSC4qT0XKO81HK94sTc4tK8dL3k /NxNjOCk8kx6B+PhXe6HGAU4GJV4eC+4pIcJsSaWFVfmHmKU4GBWEuHVv5wRJsSbklhZlVqU H19UmpNafIjRFOi/icxSosn5wISXVxJvaGxiZmRpZG5oYWRsriTOu+9SZJiQQHpiSWp2ampB ahFMHxMHp1QDY/vZ7F65po01KcdCfrf0hiosv6dQsvxdq+7e0roEh/N6uu3uVyVkD3w7GeUn mLTwdPLE7Zm/MqZVlRy2O807T7NzvsmEEruw9UadP5cen71a8bfEnqba/p8tBn+SdiW1LmmS Pir75dzTPWbeNr1y8e6iJ99HVDFYyyX46h1e+vs8u6zYgglWSizFGYmGWsxFxYkAL1zpVUAD AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 10일 10:31, Krzysztof Kozlowski wrote: > On 09.12.2015 13:08, Chanwoo Choi wrote: >> This patch updates the documentation for passive bus devices and adds the >> detailed example of Exynos3250. >> >> Signed-off-by: Chanwoo Choi >> --- >> .../devicetree/bindings/devfreq/exynos-bus.txt | 244 ++++++++++++++++++++- >> 1 file changed, 241 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt >> index 54a1f9c46c88..c4fdc70f8eac 100644 >> --- a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt >> +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt >> @@ -13,18 +13,23 @@ SoC has the different sub-blocks. So, this difference should be specified >> in devicetree file instead of each device driver. In result, this driver >> is able to support the bus frequency for all Exynos SoCs. >> >> -Required properties for bus device: >> +Required properties for all bus devices: >> - compatible: Should be "samsung,exynos-bus". >> - clock-names : the name of clock used by the bus, "bus". >> - clocks : phandles for clock specified in "clock-names" property. >> - #clock-cells: should be 1. >> - operating-points-v2: the OPP table including frequency/voltage information >> to support DVFS (Dynamic Voltage/Frequency Scaling) feature. >> + >> +Required properties for only parent bus device: > > Maybe: > "Required properties only for parent bus devices:" OK. I'll modify it. > > In this binding documentation file the idea of "parent" is not > explained. I now it is related to passive devfreq governor but looking > at the binding itself it is a new idea, not covered here. OK. I'll add the detailed description of 'parent' and correlation between 'parent' and 'passive' device. > >> - vdd-supply: the regulator to provide the buses with the voltage. >> - devfreq-events: the devfreq-event device to monitor the curret utilization >> of buses. >> >> -Optional properties for bus device: >> +Required properties for only passive bus device: > > "Required properties only for passive bus devices:" OK. I'll modify it. > >> +- devfreq: the parent bus device. >> + >> +Optional properties for only parent bus device: >> - exynos,saturation-ratio: the percentage value which is used to calibrate >> the performance count againt total cycle count. >> >> @@ -33,7 +38,20 @@ Example1: >> power line (regulator). The MIF (Memory Interface) AXI bus is used to >> transfer data between DRAM and CPU and uses the VDD_MIF regualtor. >> >> - - power line(VDD_MIF) --> bus for DMC (Dynamic Memory Controller) block >> + - MIF (Memory Interface) block >> + : VDD_MIF |--- DMC (Dynamic Memory Controller) >> + >> + - INT (Internal) block >> + : VDD_INT |--- LEFTBUS (parent device) >> + |--- PERIL >> + |--- MFC >> + |--- G3D >> + |--- RIGHTBUS >> + |--- FSYS >> + |--- LCD0 >> + |--- PERIR >> + |--- ISP >> + |--- CAM >> >> - MIF bus's frequency/voltage table >> ----------------------- >> @@ -46,6 +64,24 @@ Example1: >> |L5| 400000 |875000 | >> ----------------------- >> >> + - INT bus's frequency/voltage table >> + ---------------------------------------------------------- >> + |Block|LEFTBUS|RIGHTBUS|MCUISP |ISP |PERIL ||VDD_INT | >> + | name| |LCD0 | | | || | >> + | | |FSYS | | | || | >> + | | |MFC | | | || | >> + ---------------------------------------------------------- >> + |Mode |*parent|passive |passive|passive|passive|| | >> + ---------------------------------------------------------- >> + |Lv |Frequency ||Voltage | >> + ---------------------------------------------------------- >> + |L1 |50000 |50000 |50000 |50000 |50000 ||900000 | >> + |L2 |80000 |80000 |80000 |80000 |80000 ||900000 | >> + |L3 |100000 |100000 |100000 |100000 |100000 ||1000000 | >> + |L4 |134000 |134000 |200000 |200000 | ||1000000 | >> + |L5 |200000 |200000 |400000 |300000 | ||1000000 | >> + ---------------------------------------------------------- >> + >> Example2 : >> The bus of DMC (Dynamic Memory Controller) block in exynos3250.dtsi >> are listed below: >> @@ -84,6 +120,167 @@ Example2 : >> }; >> }; >> >> + bus_leftbus: bus_leftbus { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu CLK_DIV_GDL>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_leftbus_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_rightbus: bus_rightbus { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu CLK_DIV_GDR>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_leftbus_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_lcd0: bus_lcd0 { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu CLK_DIV_ACLK_160>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_leftbus_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_fsys: bus_fsys { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu CLK_DIV_ACLK_200>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_leftbus_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_mcuisp: bus_mcuisp { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu CLK_DIV_ACLK_400_MCUISP>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_mcuisp_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_isp: bus_isp { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu CLK_DIV_ACLK_266>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_isp_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_peril: bus_perir { > > > Peril or perir? peril is correct. I'll fix it. Best Regards, Chanwoo Choi