From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753070AbbLJGIn (ORCPT ); Thu, 10 Dec 2015 01:08:43 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:36963 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900AbbLJGIk (ORCPT ); Thu, 10 Dec 2015 01:08:40 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee691-f79766d0000012b6-96-566916e5f165 Content-transfer-encoding: 8BIT Message-id: <566916E5.5060704@samsung.com> Date: Thu, 10 Dec 2015 15:08:37 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 14/19] ARM: dts: Add bus nodes using VDD_INT for Exynos4x12 References: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> <1449634091-1842-15-git-send-email-cw00.choi@samsung.com> <56691458.9000000@samsung.com> In-reply-to: <56691458.9000000@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsWyRsSkUPepWGaYweVV0hbzj5xjteh/s5DV 4tyrlYwWr18YWvQ/fs1scbbpDbvF5V1z2Cw+9x5htJhxfh+TxbqNt9gtbl/mtVh6/SKTxe3G FWwWE6avZbFo3XuE3aJt9QdWBwGPNfPWMHq0NPeweVzu62Xy2DnrLrvHyuVf2Dw2repk8/h3 jN2jb8sqRo/Pm+QCOKO4bFJSczLLUov07RK4MrrmbmMreKZeMW3hDvYGxgb5LkZODgkBE4nP t2YyQthiEhfurWfrYuTiEBJYwSjx9lIDO0zRgSN3WSESSxklZk1dxAqS4BUQlPgx+R5LFyMH B7OAvMSRS9kgYWYBdYlJ8xYxg9hCAg8YJb5944Qo15I4d6WPCcRmEVCVOHP1HVgNG1B8/4sb bCBjRAUiJLpPVIKERQTiJTa9uAp2D7PAXSaJi++fsIEkhAVCJDbNWwN1z0JGie2rp4Adyimg LXHqzE5mkISEwA4Oib6VD1kgtglIfJt8COxQCQFZiU0HmCEek5Q4uOIGywRGsVlI3pmF8M4s JO8sYGRexSiaWpBcUJyUXmSqV5yYW1yal66XnJ+7iREY8af/PZu4g/H+AetDjAIcjEo8vBdc 0sOEWBPLiitzDzGaAh0xkVlKNDkfmFbySuINjc2MLExNTI2NzC3NlMR5daR/BgsJpCeWpGan phakFsUXleakFh9iZOLglGpgLJ/zTcB5yZUtd7SL2Po/59WdmlQbt6xMPFroRf2GmOPmp1If tpyp3KK56INYqE203/23zC4C14OZZh5bPNfstoZaUEy4j1aM0Xe3zdJzZ4uzGAvXBCxZ3zgv Z2PPwhc7xIM+2OZtermLz2j+6iCrNv6LG4zuXbwbFFh/8vhrjfVlU3zFD7KxK7EUZyQaajEX FScCAGEJPXPzAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLKsWRmVeSWpSXmKPExsVy+t9jAd2nYplhBp8uiFjMP3KO1aL/zUJW i3OvVjJavH5haNH/+DWzxdmmN+wWl3fNYbP43HuE0WLG+X1MFus23mK3uH2Z12Lp9YtMFrcb V7BZTJi+lsWide8Rdou21R9YHQQ81sxbw+jR0tzD5nG5r5fJY+esu+weK5d/YfPYtKqTzePf MXaPvi2rGD0+b5IL4IxqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xN tVVy8QnQdcvMAfpCSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5jRNXcb W8Ez9YppC3ewNzA2yHcxcnJICJhIHDhylxXCFpO4cG89WxcjF4eQwFJGiVlTF4EleAUEJX5M vsfSxcjBwSwgL3HkUjZImFlAXWLSvEXMILaQwANGiW/fOCHKtSTOXeljArFZBFQlzlx9B1bD BhTf/+IGG8gYUYEIie4TlSBhEYF4iU0vroKtZRa4yyRx8f0TNpCEsECIxKZ5a1gh7lnIKLF9 9RR2kASngLbEqTM7mScwCsxCct4shPNmITlvASPzKkaJ1ILkguKk9FyjvNRyveLE3OLSvHS9 5PzcTYzgpPJMegfj4V3uhxgFOBiVeHgvuKSHCbEmlhVX5h5ilOBgVhLhPfozI0yINyWxsiq1 KD++qDQntfgQoynQgxOZpUST84EJL68k3tDYxMzI0sjc0MLI2FxJnHffpcgwIYH0xJLU7NTU gtQimD4mDk6pBsZ1tSeSGeuu3v91wf70wjXLdtYZH2NmPrFy6qyNW7dlv6v1tD66KnyGSr/8 pIqT3tWRu5za3ggFK1+73mCf/Tv54Lza8/v3tT3t+ejW81NqUUtGeVfqAYt59+cdUTzn78lj ptf7Oez9lUs9X0O5y9Z63VPdbVgimrnygdQdrhdVt3ueHi9Yr/xXiaU4I9FQi7moOBEA4OgZ akADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 10일 14:57, Krzysztof Kozlowski wrote: > On 09.12.2015 13:08, Chanwoo Choi wrote: >> This patch adds the bus noes using VDD_INT for Exynos4x12 SoC. >> Exynos4x12 has the following AXI buses to translate data between >> DRAM and sub-blocks. >> >> Following list specifies the detailed relation between DRAM and sub-blocks: >> - ACLK100 clock for PERIL/PERIR/MFC(PCLK) >> - ACLK160 clock for CAM/TV/LCD >> : The minimum clock of ACLK160 should be over 160MHz. >> When drop the clock under 160MHz, show the broken image. >> - ACLK133 clock for FSYS >> - GDL clock for LEFTBUS >> - GDR clock for RIGHTBUS >> - SCLK_MFC clock for MFC >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm/boot/dts/exynos4x12.dtsi | 112 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 112 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi >> index 3bcf0939755e..8bc4aee156b5 100644 >> --- a/arch/arm/boot/dts/exynos4x12.dtsi >> +++ b/arch/arm/boot/dts/exynos4x12.dtsi >> @@ -354,6 +354,118 @@ >> opp-microvolt = <950000>; >> }; >> }; >> + >> + bus_leftbus: bus_leftbus { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DIV_GDL>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_leftbus_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_rightbus: bus_rightbus { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DIV_GDR>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_leftbus_opp_table>; >> + status = "disabled"; >> + }; > > These two nodes are symmetrical. The MFC below and other buses in other > DTS share opps. How about changing the binding so multiple clocks could > be specified at once ("bus0", "bus1")? I think there is no need for a > bus device for each clock. The your commented method is possible. But, I focus on implementing the generic bus frequency driver. If specific bus device-tree node includes the one more clocks, when adding the new Exynos SoC, the exynos-bus.c should be added for new Exynos SoC. Because, each Exynos SoC has the different set of bus device. If we use my approach, we don't need to modify the exynos-bus.c driver to support for the bus frequency of new Exynos SoC. Best Regards, Chanwoo Choi > > Best regards, > Krzysztof > >> + >> + bus_display: bus_display { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_ACLK160>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_display_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_fsys: bus_fsys { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_ACLK133>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_fsys_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_peri: bus_peri { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_ACLK100>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_peri_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_mfc: bus_mfc { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_SCLK_MFC>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_leftbus_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_leftbus_opp_table: opp_table3 { >> + compatible = "operating-points-v2"; >> + opp-shared; >> + >> + opp00 { >> + opp-hz = /bits/ 64 <100000000>; >> + opp-microvolt = <900000>; >> + }; >> + opp01 { >> + opp-hz = /bits/ 64 <134000000>; >> + opp-microvolt = <925000>; >> + }; >> + opp02 { >> + opp-hz = /bits/ 64 <160000000>; >> + opp-microvolt = <950000>; >> + }; >> + opp03 { >> + opp-hz = /bits/ 64 <200000000>; >> + opp-microvolt = <1000000>; >> + }; >> + }; >> + >> + bus_display_opp_table: opp_table4 { >> + compatible = "operating-points-v2"; >> + opp-shared; >> + >> + opp00 { >> + opp-hz = /bits/ 64 <160000000>; >> + opp-microvolt = <950000>; >> + }; >> + opp01 { >> + opp-hz = /bits/ 64 <200000000>; >> + opp-microvolt = <1000000>; >> + }; >> + }; >> + >> + bus_fsys_opp_table: opp_table5 { >> + compatible = "operating-points-v2"; >> + opp-shared; >> + >> + opp00 { >> + opp-hz = /bits/ 64 <100000000>; >> + opp-microvolt = <900000>; >> + }; >> + opp01 { >> + opp-hz = /bits/ 64 <134000000>; >> + opp-microvolt = <925000>; >> + }; >> + }; >> + >> + bus_peri_opp_table: opp_table6 { >> + compatible = "operating-points-v2"; >> + opp-shared; >> + >> + opp00 { >> + opp-hz = /bits/ 64 <50000000>; >> + opp-microvolt = <900000>; >> + }; >> + opp01 { >> + opp-hz = /bits/ 64 <100000000>; >> + opp-microvolt = <925000>; >> + }; >> + }; >> }; >> >> &combiner { >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >