From: Alexander Holler <holler@ahsoftware.de>
To: David Howells <dhowells@redhat.com>, jmorris@namei.org
Cc: David Woodhouse <David.Woodhouse@intel.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] X.509: Fix the time validation [ver #3]
Date: Thu, 10 Dec 2015 16:15:22 +0100 [thread overview]
Message-ID: <5669970A.9040507@ahsoftware.de> (raw)
In-Reply-To: <56694497.9090308@ahsoftware.de>
Am 10.12.2015 um 10:23 schrieb Alexander Holler:
> Am 12.11.2015 um 12:38 schrieb David Howells:
>> This fixes CVE-2015-5327. It affects kernels from 4.3-rc1 onwards.
>>
>> Fix the X.509 time validation to use month number-1 when looking up the
>> number of days in that month. Also put the month number validation
>> before
>> doing the lookup so as not to risk overrunning the array.
>
> I've just run into this with 4.3.1 (mon_len ended up with 0 because of
> the wrong index). Which means currently build stable kernels with
> signature verification might not load modules (depending on which value
> the invalid index mon_len (12) ends up with.
Just in case of, I would suggest to quickly push out 4.3.2 (only 4.3
seems to be affected) which contains at least the patch mentioned in the
subject (58585c1fc301a36625db41ac7078c4dd0a218d84 in mainline).
Regards,
Alexander Holler
next prev parent reply other threads:[~2015-12-10 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 11:38 [PATCH] X.509: Fix the time validation [ver #3] David Howells
2015-12-10 9:23 ` Alexander Holler
2015-12-10 15:15 ` Alexander Holler [this message]
2015-12-10 15:26 ` Greg Kroah-Hartman
2015-12-10 15:34 ` Alexander Holler
2015-12-10 18:00 ` Alexander Holler
2015-12-10 18:09 ` Greg Kroah-Hartman
2015-12-10 18:21 ` Alexander Holler
2015-12-11 11:13 ` David Howells
2015-12-11 12:31 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5669970A.9040507@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=David.Woodhouse@intel.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox