From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011AbbLKC2R (ORCPT ); Thu, 10 Dec 2015 21:28:17 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:53340 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911AbbLKC14 (ORCPT ); Thu, 10 Dec 2015 21:27:56 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79646d000001355-ba-566a34a9f988 Content-transfer-encoding: 8BIT Message-id: <566A34A2.7040001@samsung.com> Date: Fri, 11 Dec 2015 11:27:46 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 16/19] ARM: dts: Add PPMU node for exynos4412-odroidu3 References: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> <1449634091-1842-17-git-send-email-cw00.choi@samsung.com> <56691F54.7040704@samsung.com> In-reply-to: <56691F54.7040704@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsWyRsSkWHelSVaYwcOVyhbzj5xjteh/s5DV 4tyrlYwWr18YWvQ/fs1scbbpDbvF5V1z2Cw+9x5htJhxfh+TxbqNt9gtbl/mtVh6/SKTxe3G FWwWE6avZbFo3XuE3aJt9QdWBwGPNfPWMHq0NPeweVzu62Xy2DnrLrvHyuVf2Dw2repk8/h3 jN2jb8sqRo/Pm+QCOKO4bFJSczLLUov07RK4Mjat/c1YsJC94uHRZrYGxj+sXYwcHBICJhIH //F0MXICmWISF+6tZwOxhQRWMErcOu4PETeRuHDzDlMXIxdQfCmjxIOej0wgCV4BQYkfk++x gMxhFpCXOHIpGyTMLKAuMWneImaI+geMEucvX2ADqeEV0JL4O0kHpIZFQFVi06kGRhCbDSi8 /8UNsBJRgQiJ7hOVIGERgXiJTS+usoGMYRa4yyRx8f0TsNuEBXwlnn74xwJx50JGiV23HEBs TgFtid75axhBGiQEdnBInPnTwg6xTEDi2+RDLBD/ykpsOsAM8ZekxMEVN1gmMIrNQvLNLIRv ZiH5ZgEj8ypG0dSC5ILipPQiQ73ixNzi0rx0veT83E2MwFg//e9Z7w7G2wesDzEKcDAq8fB6 sGWFCbEmlhVX5h5iNAU6YiKzlGhyPjCh5JXEGxqbGVmYmpgaG5lbmimJ8ypK/QwWEkhPLEnN Tk0tSC2KLyrNSS0+xMjEwSnVwGgjd9IoxXuXVZG4doC3SsBxBfYME+Vpf6ZI28meYdqfwTir 5WF+g9iu1buXvZa/nl9VIch9eHVOsp5sTNFp66WTfCqdX1d+4c9RWWAm3PE5dVfDE/2yDZYh nF8C7Dj4Y3I3fRMzltkrvsBk0XEmBpak4+dd38rcuengb5i74/Qn9eWcZ84FKbEUZyQaajEX FScCAFQ/djnwAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDKsWRmVeSWpSXmKPExsVy+t9jAd2VJllhBvOnyFrMP3KO1aL/zUJW i3OvVjJavH5haNH/+DWzxdmmN+wWl3fNYbP43HuE0WLG+X1MFus23mK3uH2Z12Lp9YtMFrcb V7BZTJi+lsWide8Rdou21R9YHQQ81sxbw+jR0tzD5nG5r5fJY+esu+weK5d/YfPYtKqTzePf MXaPvi2rGD0+b5IL4IxqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xN tVVy8QnQdcvMAfpCSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5ixae1v xoKF7BUPjzazNTD+Ye1i5OSQEDCRuHDzDhOELSZx4d56ti5GLg4hgaWMEg96PoIleAUEJX5M vsfSxcjBwSwgL3HkUjZImFlAXWLSvEXMEPUPGCXOX77ABlLDK6Al8XeSDkgNi4CqxKZTDYwg NhtQeP+LG2AlogIREt0nKkHCIgLxEpteXAVbyyxwl0ni4vsnbCAJYQFfiacf/rGA2EICCxkl dt1yALE5BbQleuevYZzAKDALyXWzEK6bheS6BYzMqxglUguSC4qT0nON8lLL9YoTc4tL89L1 kvNzNzGCU8oz6R2Mh3e5H2IU4GBU4uFdwJEVJsSaWFZcmXuIUYKDWUmEN1kPKMSbklhZlVqU H19UmpNafIjRFOi/icxSosn5wHSXVxJvaGxiZmRpZG5oYWRsriTOu+9SZJiQQHpiSWp2ampB ahFMHxMHp1QDY/XqtCa2qRv+PPq41vTA3H9xcXILd1kafGX565l19svxPpd/TydOf7MjRyCo e8LMoPPBB9cU3PaavoM19oXRfrMpm7Lq7y+reP/Pfd5LnSC76RuXiZl19bpN/6iwN3KNd/G/ yqke15Qv+GsVL/7+aebODKYvc/RXLj30QPNm+zfWzx7VcSZ873cpsRRnJBpqMRcVJwIAAHpi OT8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 10일 15:44, Krzysztof Kozlowski wrote: > On 09.12.2015 13:08, Chanwoo Choi wrote: >> This patch add dt node for PPMU_{DMC0|DMC1|LEFTBUS|RIGHTBUS} for >> exynos4412-odroidu3 board. Each PPMU dt node includes one event of >> 'PPMU Count3'. >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 40 +++++++++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> > > The patch itself is good but now I see that it is duplicated with > Rinato, Monk and Trats2. Probably for all other Exynos4 and > one-cluster-Exynos5 boards this would be exactly the same as well. > > How about making a DTSI file with common PPMU events configuration? OK. I'll make the exynos4412-ppmu-common.dtsi. The Exynos4 series used the PPMU firstly. That is why deciding the filename of exynos4412-ppmu-common.dtsi. Best Regards, Chanwoo Choi