From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753072AbbLKCin (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Dec 2015 21:38:43 -0500
Received: from mailout1.w1.samsung.com ([210.118.77.11]:19773 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751890AbbLKCik (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Dec 2015 21:38:40 -0500
X-AuditID: cbfec7f5-f79b16d000005389-9d-566a372d3ebb
Subject: Re: [PATCH v4 38/58] mtd: nand: s3c2410: use the mtd instance embedded
 in struct nand_chip
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        linux-mtd@lists.infradead.org
References: <1449734442-18672-1-git-send-email-boris.brezillon@free-electrons.com>
 <1449734442-18672-39-git-send-email-boris.brezillon@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        Hartley Sweeten <hsweeten@visionengravers.com>,
        Ryan Mallon <rmallon@gmail.com>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>, Imre Kaloz <kaloz@openwrt.org>,
        Krzysztof Halasa <khalasa@piap.pl>, Tony Lindgren <tony@atomide.com>,
        linux-omap@vger.kernel.org, Alexander Clouter <alex@digriz.org.uk>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Gregory CLEMENT <gregory.clement@free-electrons.com>,
        Jason Cooper <jason@lakedaemon.net>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        Marek Vasut <marek.vasut@gmail.com>, Steven Miao <realmz6@gmail.com>,
        adi-buildroot-devel@lists.sourceforge.net,
        Mikael Starvik <starvik@axis.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>, linux-cris-kernel@axis.com,
        Josh Wu <josh.wu@atmel.com>, Wan ZongShun <mcuos.com@gmail.com>,
        Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
        Maxim Levitsky <maximlevitsky@gmail.com>,
        Kukjin Kim <kgene@kernel.org>, linux-samsung-soc@vger.kernel.org,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@csie.org>, linux-sunxi@googlegroups.com,
        Stefan Agner <stefan@agner.ch>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <566A371C.7030507@samsung.com>
Date: Fri, 11 Dec 2015 11:38:20 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-version: 1.0
In-reply-to: <1449734442-18672-39-git-send-email-boris.brezillon@free-electrons.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sf0yMcRzH973v9557Ot16XMl3Mc0RdhLJ5jMz4w/2zB/4g2ZmcurZVSrt
	Ti3Wkpq4jH4hTnHVRVKHO5l+SK6SK9tlGRMd+k3R/EjqFno003/v9+f9en/2+ePDYmWr1I+N
	ijss6OI0MSpGTtp+tbxYsWJtdOiqE2kMtNxOZeBU+k5wdtkxNAwWEWhqr8TQ23ASQdrkRwJ1
	TydkkHMjD0Nbq0kK6SW3GLBmfELQblkLhQVjMjhu7iAwYDdiqDnulsLQYDCUOqoQlJ+vJpDV
	M4Th8+QbBNaeF1Iou2nBUJRhJtBRU8BAbdo1GVw2ZxG46KyXgLv7sQya61wYqqwPMAw7imXQ
	l58C1V9MU6feq2DAOOwNI+ObYPDuXKhz7wWb5eQU8i5NAg+fb4Vxu1OyMZAvGXNh3jRRRfgf
	o7mEf2nZwd/uvinlLVcKGd5V30j4XuszxGdZvkn5amOXjK/LcTC8rUzNW8sNDJ/a4CT8w8IK
	GW8zH9vht0e+PkKIiUoUdCs37JdHDnU8wfFXPZJOXN2XigpkmciDpdwaOnnuN57WvrTddYvJ
	RHJWyZUi+sFlQtNmAtHm2lOMSHlzAh1wu/8GPpwF0QtvRiTT1BVEz5z9jkWDORNLM9///rtM
	zj3FtLH+tETsM1wItV03TwUsq+DUdNhERUm4APr6spco53C7afH9KBFWcLPpzzwXEcceXCjt
	r1wuSswF0bfP1CKBOX9qq/iEs9Fs44yC8T9lnEGZEC5Hc4SE8Hj9AW3s6iC9JlafEKcNCj8U
	a0XTHzZ6H5U+XmdHHItUngoTGx2qlGoS9Udi7YiyWOWjEEKmRooIzZGjgu5QmC4hRtDb0TyW
	qOYqLtWM7FRyWs1h4aAgxAu6f6mE9fBLRUm+peFasmXWPP/Thm7/uMzO6JT28TVLLsGZTkdz
	0bKUqMhAz8haM7PIPkAWhq929lL/xn7DnSX20XXmpcGJAb5uQ8/iJ31Ka/KBDWMT+eklub86
	9locXrnZ2+KN87eHvds11lSmbYlYkOwy1H59pA7wvTuY1+nt9UratLls/Ot+FdFHaoLVWKfX
	/AEw8DIPXQMAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10.12.2015 17:00, Boris Brezillon wrote:
> struct nand_chip now embeds an mtd device. Make use of this mtd instance.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Changes generated with the following coccinelle script
> 
> --->8---
> virtual patch
> 
> @fix1@
> identifier __chipfield, __mtdfield;
> type __type;
> @@
> (
> 	__type {
> 		...
> 		struct nand_chip __chipfield;
> 		...
> -		struct mtd_info __mtdfield;
> 		...
> 	};
> |
> 	__type {
> 		...
> -		struct mtd_info __mtdfield;
> 		...
> 		struct nand_chip __chipfield;
> 		...
> 	};
> )
> 
> @fix2 depends on fix1@
> identifier fix1.__chipfield, fix1.__mtdfield;
> identifier __subfield;
> type fix1.__type;
> __type *__priv;
> @@
> (
> -	__priv->__mtdfield.__subfield
> +	nand_to_mtd(&__priv->__chipfield)->__subfield
> |
> -	&(__priv->__mtdfield)
> +	nand_to_mtd(&__priv->__chipfield)
> )
> --->8---
> ---
>  drivers/mtd/nand/s3c2410.c | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)
> 

Looks correct:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof