From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753373AbbLKD5H (ORCPT ); Thu, 10 Dec 2015 22:57:07 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:51460 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbbLKD5C (ORCPT ); Thu, 10 Dec 2015 22:57:02 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f79646d000001316-88-566a498a77f8 Content-transfer-encoding: 8BIT Message-id: <566A4981.1050602@samsung.com> Date: Fri, 11 Dec 2015 12:56:49 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Rob Herring Cc: "myungjoo.ham@samsung.com" , =?UTF-8?B?S3J6?= =?UTF-8?B?eXN6dG9mIEtvesWCb3dza2k=?= , Kukjin Kim , Kyungmin Park , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King - ARM Linux , tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel , "linux-pm@vger.kernel.org" , linux-samsung-soc , devicetree Subject: Re: [PATCH v2 09/19] PM / devfreq: exynos: Update documentation for bus devices using passive governor References: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> <1449634091-1842-10-git-send-email-cw00.choi@samsung.com> <20151210142109.GA32109@rob-hp-laptop> <20151211032417.GA22249@rob-hp-laptop> In-reply-to: <20151211032417.GA22249@rob-hp-laptop> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsWyRsSkSLfLMyvM4GmjvMX8I+dYLfrfLGS1 OPdqJaPF6xeGFv2PXzNbnG16w25xedccNovPvUcYLWac38dksW7jLXaL25d5LZZev8hkcbtx BZvFhOlrWSz+79nBbtG2+gOrg4DHmnlrGD1amnvYPC739TJ57Jx1l91j5fIvbB6bVnWyefw7 xu7Rt2UVo8fnTXIBnFFcNimpOZllqUX6dglcGev6ZzAXnJWrOL3uImsD40fxLkYODgkBE4lX /zy6GDmBTDGJC/fWs3UxcnEICaxglFjy+hcrRMJE4uel2UwQiVmMEh9/TgJL8AoISvyYfI8F ZBCzgLzEkUvZIGFmAXWJSfMWMYPYQgIPGCV2bi+FKNeS+HzvMlgri4CqxPmGX4wgNhtQfP+L G2wgY0QFIiS6T1SChEUEFCV+t01jhRi5gVVi0yd2kBJhgUKJd19UIa6ZySRx+GYfG0gNp4Cx xJW9S5lBEhICWzgkmhv/sUDsEpD4NvkQC8S/shKbDjBDvCUpcXDFDZYJjGKzkDwzC+GZWUie WcDIvIpRNLUguaA4Kb3IRK84Mbe4NC9dLzk/dxMjMNZP/3s2YQfjvQPWhxgFOBiVeHgXcmSF CbEmlhVX5h5iNAU6YiKzlGhyPjCh5JXEGxqbGVmYmpgaG5lbmimJ876W+hksJJCeWJKanZpa kFoUX1Sak1p8iJGJg1OqgVHqwt77Rcv2CplyaLu9Dmbn5Q3naaius5+6XU92W+BfG5v2n5tS F1yq+CC45V8mT5p5X3Xoj1XP5l8zC24NnsZgNvXb1Gs3Wad3qTxkuM30e8r6yxPmBku0NcxJ bCw/zzrhv+Q3hjP3ymPOC9zSnRf9zqleTORW4rG7jTveVl1KWrv7249bSRVKLMUZiYZazEXF iQD/anWl8AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsVy+t9jQd0uz6wwg6uTJSzmHznHatH/ZiGr xblXKxktXr8wtOh//JrZ4mzTG3aLy7vmsFl87j3CaDHj/D4mi3Ubb7Fb3L7Ma7H0+kUmi9uN K9gsJkxfy2Lxf88Odou21R9YHQQ81sxbw+jR0tzD5nG5r5fJY+esu+weK5d/YfPYtKqTzePf MXaPvi2rGD0+b5IL4IxqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xN tVVy8QnQdcvMAfpCSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5ixrn8G c8FZuYrT6y6yNjB+FO9i5OSQEDCR+HlpNhOELSZx4d56ti5GLg4hgVmMEh9/TmIFSfAKCEr8 mHyPpYuRg4NZQF7iyKVskDCzgLrEpHmLmEFsIYEHjBI7t5dClGtJfL53GayVRUBV4nzDL0YQ mw0ovv/FDTaQMaICERLdJypBwiICihK/26axQozcwCqx6RM7SImwQKHEuy+qENfMZJI4fLOP DaSGU8BY4srepcwTGIFuRDhuFsJxs5Act4CReRWjRGpBckFxUnquUV5quV5xYm5xaV66XnJ+ 7iZGcEJ5Jr2D8fAu90OMAhyMSjy8CziywoRYE8uKK3MPMUpwMCuJ8L50AArxpiRWVqUW5ccX leakFh9iNAV6byKzlGhyPjDZ5ZXEGxqbmBlZGpkbWhgZmyuJ8+67FBkmJJCeWJKanZpakFoE 08fEwSnVwFikvTbM1Nfs0edlJ74fWle+dsdcQQv/pEsW6jdfJS3WT+zZOUnyA4fPl6duW3bm dmkFMB9nXx9WpfMhhTG5fKHDerfi10LP5u31eshm0HjXK6/c7f+17YKXsiamTUk8J39sDWOQ 1RkJHu0y6zMXzteln2RZHHxYTIipMcHqf8q/xQf+yQQtj1JiKc5INNRiLipOBAA3T/jgPgMA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 11일 12:24, Rob Herring wrote: > On Fri, Dec 11, 2015 at 12:10:13AM +0900, Chanwoo Choi wrote: >> On Thu, Dec 10, 2015 at 11:21 PM, Rob Herring wrote: >>> On Wed, Dec 09, 2015 at 01:08:01PM +0900, Chanwoo Choi wrote: >>>> This patch updates the documentation for passive bus devices and adds the >>>> detailed example of Exynos3250. >>>> >>>> Signed-off-by: Chanwoo Choi >>>> --- >>>> .../devicetree/bindings/devfreq/exynos-bus.txt | 244 ++++++++++++++++++++- >>>> 1 file changed, 241 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt >>>> index 54a1f9c46c88..c4fdc70f8eac 100644 >>>> --- a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt >>>> +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt >>>> @@ -13,18 +13,23 @@ SoC has the different sub-blocks. So, this difference should be specified >>>> in devicetree file instead of each device driver. In result, this driver >>>> is able to support the bus frequency for all Exynos SoCs. >>>> >>>> -Required properties for bus device: >>>> +Required properties for all bus devices: >>>> - compatible: Should be "samsung,exynos-bus". >>>> - clock-names : the name of clock used by the bus, "bus". >>>> - clocks : phandles for clock specified in "clock-names" property. >>>> - #clock-cells: should be 1. >>>> - operating-points-v2: the OPP table including frequency/voltage information >>>> to support DVFS (Dynamic Voltage/Frequency Scaling) feature. >>>> + >>>> +Required properties for only parent bus device: >>>> - vdd-supply: the regulator to provide the buses with the voltage. >>>> - devfreq-events: the devfreq-event device to monitor the curret utilization >>>> of buses. >>>> >>>> -Optional properties for bus device: >>>> +Required properties for only passive bus device: >>>> +- devfreq: the parent bus device. >>>> + >>>> +Optional properties for only parent bus device: >>>> - exynos,saturation-ratio: the percentage value which is used to calibrate >>>> the performance count againt total cycle count. >>>> >>>> @@ -33,7 +38,20 @@ Example1: >>>> power line (regulator). The MIF (Memory Interface) AXI bus is used to >>>> transfer data between DRAM and CPU and uses the VDD_MIF regualtor. >>>> >>>> - - power line(VDD_MIF) --> bus for DMC (Dynamic Memory Controller) block >>>> + - MIF (Memory Interface) block >>>> + : VDD_MIF |--- DMC (Dynamic Memory Controller) >>>> + >>>> + - INT (Internal) block >>>> + : VDD_INT |--- LEFTBUS (parent device) >>>> + |--- PERIL >>>> + |--- MFC >>>> + |--- G3D >>>> + |--- RIGHTBUS >>>> + |--- FSYS >>>> + |--- LCD0 >>>> + |--- PERIR >>>> + |--- ISP >>>> + |--- CAM >>> >>> This still has the same problem as before. I would expect that the bus >>> hierarchy in the dts match the hierarchy here. You just have flat nodes >>> in the example below. So all IP blocks affected by frequency scaling >>> should be under the bus node defining the OPPs. Something like this: >> >> The each bus of sub-block has not h/w dependency among sub-blocks >> and has the owned source clock / OPP table. Just they share the same >> power line. So, I think that flat nodes in the example below is not problem. > > I'm talking about the peripherals not described here. Is the ISP block > not a child of the bus_isp node? Same for the display controller block > and bus_lcd0. And so on. >>From the H/W point of view, ISP block is really not included in ISP's AXI bus (bus_isp). Just, the bus_isp connect to between ISP block and DRAM. Thanks, Chanwoo Choi