From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752167AbbLKHVF (ORCPT ); Fri, 11 Dec 2015 02:21:05 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:27258 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbbLKHVC (ORCPT ); Fri, 11 Dec 2015 02:21:02 -0500 X-AuditID: cbfec7f5-f79b16d000005389-58-566a795aa5b7 Subject: Re: [PATCH v3 20/20] ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3 To: Chanwoo Choi , myungjoo.ham@samsung.com, kgene@kernel.org References: <1449810479-14763-1-git-send-email-cw00.choi@samsung.com> <1449810479-14763-21-git-send-email-cw00.choi@samsung.com> Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <566A7952.700@samsung.com> Date: Fri, 11 Dec 2015 16:20:50 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1449810479-14763-21-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t/xa7pRlVlhBkfatS2uf3nOajH/yDlW i/43C1ktzr1ayWjx+oWhRf/j18wWZ5vesFtc3jWHzeJz7xFGixnn9zFZrNt4i93i9mVei6XX LzJZ3G5cwWYxYfpaFovWvUfYLdpWf2B1EPRYM28No0dLcw+bx+W+XiaPnbPusnusXP6FzWPT qk42j3/H2D36tqxi9Pi8SS6AM4rLJiU1J7MstUjfLoEr4/uVNraCJqmKbTc/sDQwHhTpYuTk kBAwkei/eYYNwhaTuHBvPZDNxSEksJRR4vvDiywgCSGBX4wSd3eFgNjCAikSK7fuYwaxRQTC JGbP+MEM0dDEKHF8fjcjiMMscJdJ4uL7J2Bj2QSMJTYvXwJm8wqoSSyafA2sm0VAVeLH4YdA Gzg4RAUiJBbtyIQoEZT4Mfke2GJOAXeJib8fsoOUMAvoSdy/qAUSZhaQl9i85i3zBEaBWUg6 ZiFUzUJStYCReRWjaGppckFxUnqukV5xYm5xaV66XnJ+7iZGSKR93cG49JjVIUYBDkYlHt4F HFlhQqyJZcWVuYcYJTiYlUR4+VOBQrwpiZVVqUX58UWlOanFhxilOViUxHln7nofIiSQnliS mp2aWpBaBJNl4uCUamA8tuLct3ulnTGhz/mfKOvdqy6U90j5P1Nzp8DPDcLSC19tE3Z14T12 KUnaUrz2w1rX7UKCHppHV2isjk6xtZsjqXho49wkldIeg/2+x+N0lFeX396tmMYackCTpyHN 3sMqP0xJcte5aemc76UPmPr0TGVc/7zy9ZTI2TNPb3r1/OXK64LiomZKLMUZiYZazEXFiQAp WcRosAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.12.2015 14:07, Chanwoo Choi wrote: > THis patch adds the bus device tree nodes for both MIF (Memory) and INT > (Internal) block to enable the bus frequency. > > The DMC bus is parent device in MIF block using VDD_MIF and the LEFTBUS > bus is parent device in INT block using VDD_INT. > > Signed-off-by: Chanwoo Choi > [linux.amoon: Tested on Odroid U3] > Tested-by: Anand Moon > --- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 47 ++++++++++++++++++++++++ > arch/arm/boot/dts/exynos4412-trats2.dts | 48 +++++++++++++++++++++++++ > 2 files changed, 95 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > index 7bd65026761e..b6818aec7cf9 100644 > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > @@ -501,3 +501,50 @@ > &watchdog { > status = "okay"; > }; > + > +&bus_acp { > + devfreq = <&bus_dmc>; > + status = "okay"; > +}; I meant put them in proper place, respecting alphabetical order. The 'b' comes before 'w'. As for the new nodes (bus_XXX) your previous sorting (first parent, then passive) was also okay - it had sense. This is up to you. Just put everything not at the end of file. Best regards, Krzysztof > + > +&bus_c2c { > + devfreq = <&bus_dmc>; > + status = "okay"; > +}; > + > +&bus_dmc { > + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; > + vdd-supply = <&buck1_reg>; > + status = "okay"; > +}; > + > +&bus_display { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_fsys { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_leftbus { > + devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>; > + vdd-supply = <&buck3_reg>; > + status = "okay"; > +}; > + > +&bus_mfc { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_peri { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_rightbus { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts > index 92438eb6eec6..0b8aff3b8cb7 100644 > --- a/arch/arm/boot/dts/exynos4412-trats2.dts > +++ b/arch/arm/boot/dts/exynos4412-trats2.dts > @@ -1251,3 +1251,51 @@ > vtmu-supply = <&ldo10_reg>; > status = "okay"; > }; > + > +&bus_acp { > + devfreq = <&bus_dmc>; > + status = "okay"; > +}; > + > +&bus_c2c { > + devfreq = <&bus_dmc>; > + status = "okay"; > +}; > + > +&bus_dmc { > + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; > + vdd-supply = <&buck1_reg>; > + status = "okay"; > +}; > + > +&bus_display { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > + > +&bus_fsys { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_leftbus { > + devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>; > + vdd-supply = <&buck3_reg>; > + status = "okay"; > +}; > + > +&bus_mfc { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_peri { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_rightbus { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; >