From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbbLKIgc (ORCPT ); Fri, 11 Dec 2015 03:36:32 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:34800 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbbLKIgL convert rfc822-to-8bit (ORCPT ); Fri, 11 Dec 2015 03:36:11 -0500 X-AuditID: cbfee68f-f793a6d000001364-10-566a8af85de3 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <566A8AEE.1020601@samsung.com> Date: Fri, 11 Dec 2015 17:35:58 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 20/20] ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3 References: <1449810479-14763-1-git-send-email-cw00.choi@samsung.com> <1449810479-14763-21-git-send-email-cw00.choi@samsung.com> <566A7952.700@samsung.com> In-reply-to: <566A7952.700@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFIsWRmVeSWpSXmKPExsWyRsSkWPdnV1aYwZqZzBbzj5xjteh/s5DV 4tyrlYwWr18YWvQ/fs1scbbpDbvF5V1z2Cw+9x5htJhxfh+TxbqNt9gtbl/mtVh6/SKTxe3G FWwWE6avZbFo3XuE3aJt9QdWBwGPNfPWMHq0NPeweVzu62Xy2DnrLrvHyuVf2Dw2repk8/h3 jN2jb8sqRo/Pm+QCOKO4bFJSczLLUov07RK4Mn7f+MFeMIWnYv6sr6wNjP85uxg5OSQETCQ+ L/3JDGGLSVy4t56ti5GLQ0hgBaPE0Q9PGGGK9ry9xwqRmMUoMfn3RnaQBK+AoMSPyfdYQGxm AXWJSfMWMUPYIhIX27awQ9jaEssWvmaGaH7AKPG47TwbRLOWxOFl61hBbBYBVYk3L28zgdhs QPH9L24A1XBwiApESHSfqAQJiwjES2x6cRXsOmaBu0wSF98/AZsjLJAisXLrPqgF8xklJkzZ CTaUE+ii9wffMUG8sJZDomV/OsQyAYlvkw+xgCyQEJCV2HQA6n1JiYMrbrBMYBSfheS3WUh+ m4Xkt1lIflvAyLKKUTS1ILmgOCm9yFivODG3uDQvXS85P3cTIzBJnP73rH8H490D1ocYBTgY lXh4PdiywoRYE8uKK3MPMZoCXTSRWUo0OR+YivJK4g2NzYwsTE1MjY3MLc2UxHkXSv0MFhJI TyxJzU5NLUgtii8qzUktPsTIxMEp1cCYslt88VmOXXMWsK1RTjfw7eQNu6vJKJPrtGea16bq mjb1yUGnmJyPFPGfa+w+6FJYLMsYcOKT1ZdFGUE68lk5+f+/e5xYy1FaXRl18orPxwkvv7Uk R9tNkjRSXe6UvOSN0vulxT+/7b77jT3/yJKGb/MedQsvkkrPWC4VPIFHY8lEL+Pfi1YqsRRn JBpqMRcVJwIATlvaDQ0DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHKsWRmVeSWpSXmKPExsVy+t9jQd0fXVlhBvu/mlvMP3KO1aL/zUJW i3OvVjJavH5haNH/+DWzxdmmN+wWl3fNYbP43HuE0WLG+X1MFus23mK3uH2Z12Lp9YtMFrcb V7BZTJi+lsWide8Rdou21R9YHQQ81sxbw+jR0tzD5nG5r5fJY+esu+weK5d/YfPYtKqTzePf MXaPvi2rGD0+b5IL4IxqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xN tVVy8QnQdcvMAfpCSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5hx6eRh poI/3BWH775gaWB8ztnFyMkhIWAiseftPVYIW0ziwr31bF2MXBxCArMYJSb/3sgOkuAVEJT4 MfkeSxcjBwezgLzEkUvZIGFmAXWJSfMWMUPUP2CUeNx2ng2iXkvi8LJ1YENZBFQl3ry8zQRi swHF97+4wQYyR1QgQqL7RCVIWEQgXmLTi6tge5kF7jJJXHz/BGyOsECKxMqt+6AWzGeUmDBl J9hQTqDN7w++Y5rACHQmwn2zEO6bheS+BYzMqxglUguSC4qT0nMN81LL9YoTc4tL89L1kvNz NzGC08ozqR2MB3e5H2IU4GBU4uFdwJEVJsSaWFZcmXuIUYKDWUmElz8VKMSbklhZlVqUH19U mpNafIjRFOjBicxSosn5wJSXVxJvaGxiZmRpZG5oYWRsriTOW3spMkxIID2xJDU7NbUgtQim j4mDU6qBcZJG5q+Hz+vUw4xPyt+VudHXqZ8wT3Xh2t5X1Ynx1puuima/LfHU6pD38OdU38ap wqvy3naPyLQ6ST9tC8/oez8FbG2mnbhcL30veYqZ7Qz23oJlfNfb3P5Xetw/+MJqXlkM85TL zRcPO2692XJIi6c7z+eTpu+cjiMJilH9v/4Ui8Rvd/ZTYinOSDTUYi4qTgQAc8walUEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 11일 16:20, Krzysztof Kozlowski wrote: > On 11.12.2015 14:07, Chanwoo Choi wrote: >> THis patch adds the bus device tree nodes for both MIF (Memory) and INT >> (Internal) block to enable the bus frequency. >> >> The DMC bus is parent device in MIF block using VDD_MIF and the LEFTBUS >> bus is parent device in INT block using VDD_INT. >> >> Signed-off-by: Chanwoo Choi >> [linux.amoon: Tested on Odroid U3] >> Tested-by: Anand Moon >> --- >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 47 ++++++++++++++++++++++++ >> arch/arm/boot/dts/exynos4412-trats2.dts | 48 +++++++++++++++++++++++++ >> 2 files changed, 95 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >> index 7bd65026761e..b6818aec7cf9 100644 >> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >> @@ -501,3 +501,50 @@ >> &watchdog { >> status = "okay"; >> }; >> + >> +&bus_acp { >> + devfreq = <&bus_dmc>; >> + status = "okay"; >> +}; > > I meant put them in proper place, respecting alphabetical order. The 'b' > comes before 'w'. > > As for the new nodes (bus_XXX) your previous sorting (first parent, then > passive) was also okay - it had sense. This is up to you. Just put > everything not at the end of file. OK. I'll reorder them. Thanks for review. [snip] Best Regards, Chanwoo Choi