* [PATCH] scsi_dh_alua: fix build warning
@ 2015-12-11 8:36 Sudip Mukherjee
2015-12-11 8:37 ` Hannes Reinecke
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2015-12-11 8:36 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: linux-kernel, linux-scsi, Sudip Mukherjee, Hannes Reinecke
We were getting build warning about unused variables "vpd_pg83" and "d"
Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
build warning with next-20151211 and build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206
---
drivers/scsi/device_handler/scsi_dh_alua.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index f100cbb..5a328bf 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -320,8 +320,6 @@ static int alua_check_tpgs(struct scsi_device *sdev)
*/
static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h)
{
- unsigned char *d;
- unsigned char __rcu *vpd_pg83;
int rel_port = -1, group_id;
group_id = scsi_vpd_tpg_id(sdev, &rel_port);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi_dh_alua: fix build warning
2015-12-11 8:36 [PATCH] scsi_dh_alua: fix build warning Sudip Mukherjee
@ 2015-12-11 8:37 ` Hannes Reinecke
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2015-12-11 8:37 UTC (permalink / raw)
To: Sudip Mukherjee, James E.J. Bottomley, Martin K. Petersen
Cc: linux-kernel, linux-scsi
On 12/11/2015 09:36 AM, Sudip Mukherjee wrote:
> We were getting build warning about unused variables "vpd_pg83" and "d"
>
> Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> build warning with next-20151211 and build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206
> ---
>
> drivers/scsi/device_handler/scsi_dh_alua.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index f100cbb..5a328bf 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -320,8 +320,6 @@ static int alua_check_tpgs(struct scsi_device *sdev)
> */
> static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h)
> {
> - unsigned char *d;
> - unsigned char __rcu *vpd_pg83;
> int rel_port = -1, group_id;
>
> group_id = scsi_vpd_tpg_id(sdev, &rel_port);
>
A fix for this is already queued in Martin Petersens tree.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-11 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-11 8:36 [PATCH] scsi_dh_alua: fix build warning Sudip Mukherjee
2015-12-11 8:37 ` Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).