From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbbLKU53 (ORCPT ); Fri, 11 Dec 2015 15:57:29 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:36492 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753101AbbLKU51 (ORCPT ); Fri, 11 Dec 2015 15:57:27 -0500 Subject: Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write To: David Eccher , Felipe Balbi References: <1449863786-7697-1-git-send-email-d.eccher@gmail.com> Cc: Greg Kroah-Hartman , Al Viro , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <566B38B3.8000106@cogentembedded.com> Date: Fri, 11 Dec 2015 23:57:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1449863786-7697-1-git-send-email-d.eccher@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 12/11/2015 10:56 PM, David Eccher wrote: > Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, > hence it must exit with spinlock held to avoid double unlock in dev_config. > > Signed-off-by: David Eccher > --- > drivers/usb/gadget/legacy/inode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c > index f454c7a..b968c25 100644 > --- a/drivers/usb/gadget/legacy/inode.c > +++ b/drivers/usb/gadget/legacy/inode.c > @@ -1144,6 +1144,7 @@ ep0_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) > } else > retval = len; > > + spin_lock_irq (&dev->lock); I guess you hadn't run the patch thru scripts/checkpatch.pl? MBR, Sergei