From: Laura Abbott <labbott@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>,
Laura Abbott <labbott@fedoraproject.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] module: Limit line length of module prints
Date: Fri, 11 Dec 2015 14:25:44 -0800 [thread overview]
Message-ID: <566B4D68.20409@redhat.com> (raw)
In-Reply-To: <87a8phgw83.fsf@rustcorp.com.au>
On 12/11/2015 01:39 AM, Rusty Russell wrote:
> Laura Abbott <labbott@fedoraproject.org> writes:
>> print_modules currently uses pr_cont to print all module information.
>> This has the side effect of printing lots of modules on one very long
>> line. This makes copy/pasting oopses more effort if manual wrapping is
>> required. Place a reasonable limit (80 chars) on the number of modules
>> on each line.
>>
>> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
>> ---
>> Does this bother anyone else or am I the only one who hates dealing
>> with the long lines of "Modules linked in"?
>
> Never bothered me, but I'm a bit odd :) I worry more about the effect
> on machine parsing.
>
Yes, that was a concern I had as well, but the module list seems to get
wrapped eventually (although at a much longer length) so it seems like
if machine parsing can handle one wrap it can handle multiple wraps.
> Cheers,
> Rusty.
>
Thanks,
Laura
next prev parent reply other threads:[~2015-12-11 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 1:50 [RFC][PATCH] module: Limit line length of module prints Laura Abbott
2015-12-11 9:39 ` Rusty Russell
2015-12-11 22:25 ` Laura Abbott [this message]
2015-12-14 1:06 ` Rusty Russell
2015-12-15 22:47 ` Laura Abbott
[not found] ` <CAGG-pUT9stutifHDUyD8WiFaU5Ysp1vVaRpu7tShZEQEV+7Daw@mail.gmail.com>
2015-12-11 22:22 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566B4D68.20409@redhat.com \
--to=labbott@redhat.com \
--cc=labbott@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox