From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754603AbbLLCeZ (ORCPT ); Fri, 11 Dec 2015 21:34:25 -0500 Received: from regular1.263xmail.com ([211.150.99.130]:52115 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754349AbbLLCeW (ORCPT ); Fri, 11 Dec 2015 21:34:22 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: mark.rutland@arm.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v1 7/8] ARM: dts: rockchip: add core rk3228 dtsi To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1449651853-1667-1-git-send-email-jeffy.chen@rock-chips.com> <24573164.okRNXjvZ1B@phil> <566A2CB7.4050801@rock-chips.com> <7783766.YsX4m8bWe1@diego> Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Mark Rutland From: Jeffy Chen Message-ID: <566B8799.2060704@rock-chips.com> Date: Sat, 12 Dec 2015 10:34:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <7783766.YsX4m8bWe1@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 2015-12-11 18:12, Heiko Stübner wrote: > Hi Jeffy, > > Am Freitag, 11. Dezember 2015, 09:53:59 schrieb Jeffy Chen: >> On 2015-12-10 8:32, Heiko Stuebner wrote: >>> Am Mittwoch, 9. Dezember 2015, 17:04:12 schrieb Jeffy Chen: >>>> Initial release for rk3228 shared dtsi. >>>> >>>> Signed-off-by: Jeffy Chen >>>> --- >>>> >>>> arch/arm/boot/dts/rk3228.dtsi | 478 >>>> ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 478 >>>> insertions(+) >>>> create mode 100644 arch/arm/boot/dts/rk3228.dtsi >>>> >>>> diff --git a/arch/arm/boot/dts/rk3228.dtsi >>>> b/arch/arm/boot/dts/rk3228.dtsi >>>> new file mode 100644 >>>> index 0000000..d6b3e40 >>>> --- /dev/null >>>> +++ b/arch/arm/boot/dts/rk3228.dtsi >>>> @@ -0,0 +1,478 @@ >>>> +/* >>>> + * This file is dual-licensed: you can use it either under the terms >>>> + * of the GPL or the X11 license, at your option. Note that this dual >>>> + * licensing only applies to this file, and not this project as a >>>> + * whole. >>>> + * >>>> + * a) This file is free software; you can redistribute it and/or >>>> + * modify it under the terms of the GNU General Public License as >>>> + * published by the Free Software Foundation; either version 2 of >>>> the >>>> + * License, or (at your option) any later version. >>>> + * >>>> + * This file is distributed in the hope that it will be useful, >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + * >>>> + * Or, alternatively, >>>> + * >>>> + * b) Permission is hereby granted, free of charge, to any person >>>> + * obtaining a copy of this software and associated documentation >>>> + * files (the "Software"), to deal in the Software without >>>> + * restriction, including without limitation the rights to use, >>>> + * copy, modify, merge, publish, distribute, sublicense, and/or >>>> + * sell copies of the Software, and to permit persons to whom the >>>> + * Software is furnished to do so, subject to the following >>>> + * conditions: >>>> + * >>>> + * The above copyright notice and this permission notice shall be >>>> + * included in all copies or substantial portions of the Software. >>>> + * >>>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >>>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >>>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >>>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >>>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >>>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >>>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >>>> + * OTHER DEALINGS IN THE SOFTWARE. >>>> + */ >>>> + >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include "skeleton.dtsi" >>>> + >>>> +/ { >>>> + compatible = "rockchip,rk3228"; >>>> + >>>> + interrupt-parent = <&gic>; >>>> + >>>> + aliases { >>>> + serial0 = &uart0; >>>> + serial1 = &uart1; >>>> + serial2 = &uart2; >>>> + }; >>>> + >>>> + memory { >>>> + device_type = "memory"; >>>> + reg = <0x60000000 0x40000000>; >>>> + }; >>> The amount of memory is a property of the board >> done. >> >>>> + >>>> + cpus { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>> no enable-method? >>> >>> As the rk3228 also does not have a pmu, does the newly created >>> "rockchip,rk3036-smp" work for you? >> unlucky, that doesn't work...and our 3.10 kernel is using psci for >> rk3228's smp ops, maybe i should check that too, but i know nothing >> about psci for now :( > Using PSCI on more rockchip socs will make the ARM people very happy ;-) . > > So definitly no argument from me against it. I guess you should only need the > enable-method and psci node you should already have in your 3.10 dts, to > actually enable it. > > cpu@xxx { > enable-method = "psci"; > }; > > psci { > compatible = "arm,psci-0.2"; > ... > }; > > > But we can of course add that in a later patch as well. > > > Heiko > yes, you're right~ after added psci node and enabled CONFIG_ARM_PSCI, it could bring up all cpus : [ 0.090371] CPU0: thread -1, cpu 0, socket 15, mpidr 80000f00 [ 0.091018] Setting up static identity map for 0x60100000 - 0x60100058 [ 0.095260] CPU1: thread -1, cpu 1, socket 15, mpidr 80000f01 [ 0.096648] CPU2: thread -1, cpu 2, socket 15, mpidr 80000f02 [ 0.098070] CPU3: thread -1, cpu 3, socket 15, mpidr 80000f03 [ 0.098228] Brought up 4 CPUs [ 0.100145] SMP: Total of 4 processors activated (192.00 BogoMIPS). [ 0.100732] CPU: All CPU(s) started in SVC mode. patch coming :)