From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932122AbbLNIrf (ORCPT ); Mon, 14 Dec 2015 03:47:35 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:54530 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbbLNIrc convert rfc822-to-8bit (ORCPT ); Mon, 14 Dec 2015 03:47:32 -0500 X-AuditID: cbfee68e-f793c6d00000136c-8e-566e82214eb9 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <566E8216.4020601@samsung.com> Date: Mon, 14 Dec 2015 17:47:18 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: myungjoo.ham@samsung.com, =?UTF-8?B?7YGs7Ims7Iuc7Yag7ZSE?= , "kgene@kernel.org" Cc: =?UTF-8?B?67CV6rK966+8?= , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "linux@arm.linux.org.uk" , "tjakobi@math.uni-bielefeld.de" , "linux.amoon@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v4 02/20] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver References: <1393132421.659011450082398931.JavaMail.weblogic@epmlwas07b> In-reply-to: <1393132421.659011450082398931.JavaMail.weblogic@epmlwas07b> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsWyRsSkWFexKS/M4MhfTYv5R86xWvS/Wchq ce7VSkaL1y8MLfofv2a2ONv0ht3i8q45bBafe48wWsw4v4/JYt3GW+wWty/zWiy9fpHJ4nbj CjaLCdPXsli07j3CbtG2+gOrg4DHmnlrGD1amnvYPC739TJ57Jx1l91j5fIvbB6bVnWyefw7 xu7Rt2UVo8fnTXIBnFFcNimpOZllqUX6dglcGRd3b2Mv2C9cMbNLoIHxGX8XIyeHhICJxINf nawQtpjEhXvr2boYuTiEBFYwSnT2LmWGKXrWc4oFIjGLUaLn8TFGkASvgKDEj8n3gBIcHMwC 6hJTpuSChJkFRCQavr1lg7C1JZYtfM0M0fuAUeLagftMEL1aEm2T/4AVsQioSjTvmA22jA0o vv/FDTaQmaICERLdJypBekUEmhklPl/sYYEY+oRVYvUHbRBbWCBf4vyq6+wgtpCAh8SLdwfB vuEU8JSY9PE+2NESAms5JL5cgviGRUBA4tvkQ2BHSwjISmw6APWkpMTBFTdYJjCKz0Ly2iyE 12YheW0WktcWMLKsYhRNLUguKE5KLzLSK07MLS7NS9dLzs/dxAhMD6f/PevbwXjzgPUhRgEO RiUe3oxluWFCrIllxZW5hxhNgQ6ayCwlmpwPTEJ5JfGGxmZGFqYmpsZG5pZmSuK8CVI/g4UE 0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUwtrrf87594OCBKWkrvRVyJFeYv5jNp+B/+9Ujln/u Ndc3mIT4HbxgvbX3w8Qqe89nH97tCWmfW83GnlL2Zq7o441LGtjKBQ+wzai0YTnRKWd0mV1V 2lm6U2p1to3F1luVb9hPiN5c7Xdc3nHfw52B2X0fmey3ZU9VVOC6cNLhheCPSWt9w88LKrEU ZyQaajEXFScCAP1DhTgKAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFKsWRmVeSWpSXmKPExsVy+t9jQV3Fprwwg5WblS3mHznHatH/ZiGr xblXKxktXr8wtOh//JrZ4mzTG3aLy7vmsFl87j3CaDHj/D4mi3Ubb7Fb3L7Ma7H0+kUmi9uN K9gsJkxfy2LRuvcIu0Xb6g+sDgIea+atYfRoae5h87jc18vksXPWXXaPlcu/sHlsWtXJ5vHv GLtH35ZVjB6fN8kFcEY1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam 2iq5+AToumXmAH2hpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcz4cfoM e8Fa4YoV+6waGK/wdzFyckgImEg86znFAmGLSVy4t56ti5GLQ0hgFqNEz+NjjCAJXgFBiR+T 7wEVcXAwC8hLHLmUDWGqS0yZkgtR/oBR4tqB+0wQ5VoSbZP/sIHYLAKqEs07ZjOD2GxA8f0v brCB9IoKREh0n6gE6RURaGaU+HyxB+wGZoEnrBKrP2iD2MIC+RLnV11nB7GFBDwkXrw7yApi cwp4Skz6eJ9lAiPQkQjXzUK4bhbCdQsYmVcxSqQWJBcUJ6XnGuWllusVJ+YWl+al6yXn525i BKeTZ9I7GA/vcj/EKMDBqMTDm7ksN0yINbGsuDL3EKMEB7OSCG+CVV6YEG9KYmVValF+fFFp TmrxIUZToPcmMkuJJucDU11eSbyhsYmZkaWRuaGFkbG5kjjvvkuRYUIC6YklqdmpqQWpRTB9 TBycUg2Mh9+9qlByVTHPjHsfX5MwXTTltG5hxwQdiTRFt/A+M8OtWhsiOa9rM60sEls1szyj tmB+RWjS1ImTPHZHLF/pzrnhpL/t1OXLbl9c0bTOsjXybH2dD/eThStYN6sn/eWw1b6+IUFh v/GFN30fXn4tVo1bWj3B9xXLjw1+6nc0i41nrX0T/DNYiaU4I9FQi7moOBEAs/TpGD0DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 14일 17:40, MyungJoo Ham wrote: >> >> This patch adds the documentation for generic exynos bus frequency >> driver. >> >> Signed-off-by: Chanwoo Choi >> Reviewed-by: Krzysztof Kozlowski > > A little changes following: > >> --- >> .../devicetree/bindings/devfreq/exynos-bus.txt | 93 ++++++++++++++++++++++ >> 1 file changed, 93 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt >> >> diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt >> new file mode 100644 >> index 000000000000..e32daef328da >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt >> @@ -0,0 +1,93 @@ >> +* Generic Exynos Bus frequency device >> + >> +The Samsung Exynos SoC have many buses for data transfer between DRAM > > +The Samsung Exynos SoC has many buses for data transfer between DRAM > > or > > +The Samsung Exynos SoCs have many buses for data transfer between DRAM > (because you intend to support mulitple Exynos SoCs) > >> +and sub-blocks in SoC. Almost Exynos SoC have the common architecture > > +and sub-blocks in SoC. Most Exynos SoCs share the common architecture > >> +for buses. Generally, the each bus of Exynos SoC includes the source clock > > +for buses. Generally, each bus of Exynos SoC includes a source clock > >> +and power line and then is able to change the clock according to the usage > > +and a power line, which are able to change the clock frequency > >> +of each buses on runtime. When gathering the usage of each buses on runtime, > > +of the bus in runtime. To monitor the usage of each bus in runtime, > >> +the driver uses the PPMU (Platform Performance Monitoring Unit) which > > +the driver uses the PPMU (Platform Performance Monitoring Unit), which > >> +is able to measure the current load of sub-blocks. >> + >> +There are a little different composition among Exynos SoC because each Exynos >> +SoC has the different sub-blocks. So, this difference should be specified > > +SoC has different sub-blocks. Therefore, such difference should be specified > >> +in devicetree file instead of each device driver. In result, this driver >> +is able to support the bus frequency for all Exynos SoCs. >> + Okay. I'll modify it. Regards, Chanwoo Choi