From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbbLNJVq (ORCPT ); Mon, 14 Dec 2015 04:21:46 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:64847 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752612AbbLNJVo (ORCPT ); Mon, 14 Dec 2015 04:21:44 -0500 X-AuditID: cbfec7f5-f79b16d000005389-35-566e8a25d08f Message-id: <566E8A23.60108@samsung.com> Date: Mon, 14 Dec 2015 10:21:39 +0100 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Bryan Wu , Linus Walleij , Richard Purdie , linux-leds@vger.kernel.org Subject: Re: [PATCH 0/3] leds: avoid module usage in non-modular code References: <1450043151-30820-1-git-send-email-paul.gortmaker@windriver.com> In-reply-to: <1450043151-30820-1-git-send-email-paul.gortmaker@windriver.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsVy+t/xK7qqXXlhBgemc1kc3TmRyWLKn+VM Fpd3zWGz2PpmHaPFtb3HmS1273rK6sDmsXPWXXaPO9f2sHnsmf+D1ePzJjmP9Vu2MgWwRnHZ pKTmZJalFunbJXBlvNssV7BSoGLO51amBsYm3i5GTg4JAROJNz/7WSBsMYkL99azdTFycQgJ LGWUWHllJiuE84xR4vrGmWwgVbwCGhJfPp9kArFZBFQluqa+ButmEzCU+PniNVhcVCBC4s/p fawQ9YISPybfA6sRAapZ9mYD2FBmgbWMEmdvfwUbKizgKnGm+xdYg5CAj8Tli4/AGjgFfCW+ TdgDNpRZwFpi5aRtjBC2vMTmNW+ZJzAKzEKyYxaSsllIyhYwMq9iFE0tTS4oTkrPNdIrTswt Ls1L10vOz93ECAnurzsYlx6zOsQowMGoxMObsSw3TIg1say4MvcQowQHs5IIb4JVXpgQb0pi ZVVqUX58UWlOavEhRmkOFiVx3pm73ocICaQnlqRmp6YWpBbBZJk4OKUaGMOOHTxxzG/PuxLT jlu2TKF+zb/mZORMzFl/+vu7WYJ7W89HRMkyZctesF34KWbuoQ7F52tiQryKJH/wPy8yvrdh aciJhoup0QH9pzJ2pa1d1l64Z58Q46LX8VN43OqUj9m3igX0N9RqRRyOPq6stD+2YKVqw7q5 n09qOslLsjGaWF/M4U9QU2Ipzkg01GIuKk4EAO7V+vxqAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13/2015 10:45 PM, Paul Gortmaker wrote: > This series of commits is a part of a larger project to ensure > people don't reference modular support functions in non-modular > code. Overall there was roughly 5k lines of dead code in the > kernel due to this. So far we've fixed several areas, like tty, > x86, net, ... and we continue to work on other areas. > > There are several reasons to not use module support for code that > can never be built as a module, but the big ones are: > > (1) it is easy to accidentally code up unused module_exit and remove code > (2) it can be misleading when reading the source, thinking it can be > modular when the Makefile and/or Kconfig prohibit it > (3) it requires the include of the module.h header file which in turn > includes nearly everything else. > > For the LED subsystem, there are just three commits. Two are basically > trivial remapping to the appropriate non-modular counterparts. The > third also has a change to block driver unbinding since that doesn't > make any sense and it allows us to delete the .remove code. We've > already made similar unbind changes like this in drivers/tty. > > Patches created on linux-next and build tested for ARM allmodconfig. > > Paul. > --- > > Cc: Bryan Wu > Cc: Linus Walleij > Cc: Jacek Anaszewski > Cc: Richard Purdie > Cc: linux-leds@vger.kernel.org > > Paul Gortmaker (3): > drivers/leds: make trigger/ledtrig-cpu.c driver explicitly non-modular > drivers/leds: make trigger/ledtrig-ide-disk.c driver explicitly non-modular > drivers/leds: make leds-syscon.c explicitly non-modular > > drivers/leds/leds-syscon.c | 18 +++--------------- > drivers/leds/trigger/ledtrig-cpu.c | 26 +------------------------- > drivers/leds/trigger/ledtrig-ide-disk.c | 14 +------------- > 3 files changed, 5 insertions(+), 53 deletions(-) > Patch set applied, thanks. -- Best Regards, Jacek Anaszewski