From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932295AbbLNKWJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Dec 2015 05:22:09 -0500
Received: from mailout4.w1.samsung.com ([210.118.77.14]:8582 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932175AbbLNKWE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Dec 2015 05:22:04 -0500
X-AuditID: cbfec7f4-f79026d00000418a-c2-566e9849c119
Subject: Re: [PATCH 01/38] arm-cci: fix handling cpumask_any_but return value
To: linux-kernel@vger.kernel.org
References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com>
 <1442842450-29769-2-git-send-email-a.hajda@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
        Punit Agrawal <punit.agrawal@arm.com>,
        Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
        Mark Rutland <mark.rutland@arm.com>
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <566E9803.1030409@samsung.com>
Date: Mon, 14 Dec 2015 11:20:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-version: 1.0
In-reply-to: <1442842450-29769-2-git-send-email-a.hajda@samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsVy+t/xa7peM/LCDBblWPyddIzdYuOM9awW
	l3fNYbNYe+Quu8XS6xeZLJ6/P81kMfP2bUaLlx9PsDhweKyZt4bR4/evSYwefVtWMXp83iQX
	wBLFZZOSmpNZllqkb5fAldH0h79gO0fFvtUeDYxv2boYOTkkBEwk1r+bxwhhi0lcuLceKM7F
	ISSwlFGi598DRgjnOaPE0q+7mboYOTiEBXwlPv9IAmkQEVCQ2Nz7jBUkLCRQK7FkohZIObPA
	SiaJ/ssPmEBq2AQ0Jf5uvgm2jFdAS+JwTxuYzSKgKtH4+hYLSK+oQITEoh2ZECWCEj8m32MB
	sTkFXCQWXt3JDlLCLKAncf+iFkiYWUBeYvOat8wTGAVmIemYhVA1C0nVAkbmVYyiqaXJBcVJ
	6bmGesWJucWleel6yfm5mxghgf1lB+PiY1aHGAU4GJV4eDOW5YYJsSaWFVfmHmKU4GBWEuFN
	sMoLE+JNSaysSi3Kjy8qzUktPsQozcGiJM47d9f7ECGB9MSS1OzU1ILUIpgsEwenVAOjv3Ra
	gdAH92hGhYDukCVemn0loq/6fVTsutl+XtR780vntdtJf6urp06ndDOf2HPCrvzkrhk2y/5c
	7p6j2Hfl0LS1pc9nGp40eCuaVrh/1Y8Fn92viqXG261Xui68RfLiarYIoQsmGgr7knRWqlRf
	Y414Ldtb7/39TJ7XqtWOeVX3OcPZr6gpsRRnJBpqMRcVJwIAeT3KGGgCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Ping - almost three months passed.

Regards
Andrzej

On 09/21/2015 03:33 PM, Andrzej Hajda wrote:
> cpumask_any_but returns value >= nr_cpu_ids if there are no more CPUs.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/bus/arm-cci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 577cc4b..22754d0 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -1314,7 +1314,7 @@ static int cci_pmu_cpu_notifier(struct notifier_block *self,
>  		if (!cpumask_test_and_clear_cpu(cpu, &cci_pmu->cpus))
>  			break;
>  		target = cpumask_any_but(cpu_online_mask, cpu);
> -		if (target < 0) // UP, last CPU
> +		if (target >= nr_cpu_ids) // UP, last CPU
>  			break;
>  		/*
>  		 * TODO: migrate context once core races on event->ctx have