From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932415AbbLNKf3 (ORCPT ); Mon, 14 Dec 2015 05:35:29 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:15922 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932175AbbLNKfZ (ORCPT ); Mon, 14 Dec 2015 05:35:25 -0500 X-AuditID: cbfec7f4-f79026d00000418a-94-566e9b6be0ac Subject: Re: [PATCH 11/19] clocksource: fix __ftm_clk_init result To: linux-kernel@vger.kernel.org References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> <1443103227-25612-12-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , Daniel Lezcano , Thomas Gleixner From: Andrzej Hajda Message-id: <566E9B27.9010804@samsung.com> Date: Mon, 14 Dec 2015 11:34:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1443103227-25612-12-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t/xq7rZs/PCDP73iVlsnLGe1WLeZ1mL y7vmsFmsPXKX3WLzpqnMDqwed67tYfN4d+4cu0ffllWMHp83yQWwRHHZpKTmZJalFunbJXBl rDz4lKXgj0DF5lOtzA2MJ3i7GDk5JARMJK62XWSGsMUkLtxbz9bFyMUhJLCUUeLt3CdsIAkh geeMEqv/FoDYwgKOEguWLAVrEBFQkNjc+4wVoqZOYs7HTnaQZmaBvYwSN7e8ZAdJsAloSvzd fBNsEK+AlkTT8sksIDaLgKrEw1XLGbsYOThEBSIkFu3IhCgRlPgx+R5YCaeAq8Tnlk4mkBJm AT2J+xe1QMLMAvISm9e8ZZ7AKDALSccshKpZSKoWMDKvYhRNLU0uKE5KzzXUK07MLS7NS9dL zs/dxAgJ4C87GBcfszrEKMDBqMTDm7EsN0yINbGsuDL3EKMEB7OSCG+CVV6YEG9KYmVValF+ fFFpTmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZODilGhhz/OL9Ff57d9yo1by65/iD aVcW6/TGz5d64/Q2Yfqu22U7o+Ztfmm1ROZlFmOPr+CTsPNrvJeFfKn19/WPkgvcmT4pc+Xu 17Ipa7ISDCdoWES4suraava0HfQ8bVrb5qS8f9HitO637Janjy5z6ClZVuZzaKP/tvz/gqnl tVOV7npIfH81S12JpTgj0VCLuag4EQAfuxBpXAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Ping. Regards Andrzej On 09/24/2015 04:00 PM, Andrzej Hajda wrote: > The function tries to return clock frequency (unsigned long) or error > (int < 0). Using int as a result could be dangerous. On the other side > caller is not interested in error value, so the best solution is to > return frequency or zero in case of error, for this unsigned long is OK. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda > --- > Hi, > > To avoid problems with too many mail recipients I have sent whole > patchset only to LKML. Anyway patches have no dependencies. > > Regards > Andrzej > --- > drivers/clocksource/fsl_ftm_timer.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clocksource/fsl_ftm_timer.c b/drivers/clocksource/fsl_ftm_timer.c > index ef43469..11a7ae7 100644 > --- a/drivers/clocksource/fsl_ftm_timer.c > +++ b/drivers/clocksource/fsl_ftm_timer.c > @@ -248,7 +248,7 @@ static int __init ftm_clocksource_init(unsigned long freq) > return 0; > } > > -static int __init __ftm_clk_init(struct device_node *np, char *cnt_name, > +static unsigned long __init __ftm_clk_init(struct device_node *np, char *cnt_name, > char *ftm_name) > { > struct clk *clk; > @@ -257,19 +257,19 @@ static int __init __ftm_clk_init(struct device_node *np, char *cnt_name, > clk = of_clk_get_by_name(np, cnt_name); > if (IS_ERR(clk)) { > pr_err("ftm: Cannot get \"%s\": %ld\n", cnt_name, PTR_ERR(clk)); > - return PTR_ERR(clk); > + return 0; > } > err = clk_prepare_enable(clk); > if (err) { > pr_err("ftm: clock failed to prepare+enable \"%s\": %d\n", > cnt_name, err); > - return err; > + return 0; > } > > clk = of_clk_get_by_name(np, ftm_name); > if (IS_ERR(clk)) { > pr_err("ftm: Cannot get \"%s\": %ld\n", ftm_name, PTR_ERR(clk)); > - return PTR_ERR(clk); > + return 0; > } > err = clk_prepare_enable(clk); > if (err)