[PATCH] Coding style cleanup

[PATCH] Coding style cleanup

[Ben Gilbert]

Fixed commenting style warnings.

Signed-off-by: Ben Gilbert <gillie59978@gmail.com>
---
 drivers/staging/fbtft/fb_uc1701.c | 53 ++++++++++++++++++++++++++-------------
 1 file changed, 35 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/fbtft/fb_uc1701.c b/drivers/staging/fbtft/fb_uc1701.c
index 212908e..5f6c96a 100644
--- a/drivers/staging/fbtft/fb_uc1701.c
+++ b/drivers/staging/fbtft/fb_uc1701.c
@@ -125,17 +125,25 @@ static int init_display(struct fbtft_par *par)
 static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 {
 	/* goto address */
-	/* LCD_PAGE_ADDRESS | ((page) & 0x1F),
-	 (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
-	 LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F) */
+	/*
+	 * LCD_PAGE_ADDRESS | ((page) & 0x1F),
+	 * (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
+	 * LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F)
+	 */
 	write_reg(par, LCD_PAGE_ADDRESS);
-	/* LCD_PAGE_ADDRESS | ((page) & 0x1F),
-	 (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
-	  LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F) */
+
+	/*
+	 * LCD_PAGE_ADDRESS | ((page) & 0x1F),
+	 * (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
+	 * LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F)
+	 */
 	write_reg(par, 0x00);
-	/* LCD_PAGE_ADDRESS | ((page) & 0x1F),
-	 (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
-	  LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F) */
+
+	/*
+	 * LCD_PAGE_ADDRESS | ((page) & 0x1F),
+	 * (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
+	 *  LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F)
+	 */
 	write_reg(par, LCD_COL_ADDRESS);
 }
 
@@ -156,17 +164,26 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
 					 1 : 0) << i;
 			buf++;
 		}
-		/* LCD_PAGE_ADDRESS | ((page) & 0x1F),
-		 (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
-		  LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F) */
+
+		/*
+		 * LCD_PAGE_ADDRESS | ((page) & 0x1F),
+		 * (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
+		 * LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F)
+		 */
 		write_reg(par, LCD_PAGE_ADDRESS | (u8)y);
-		/* LCD_PAGE_ADDRESS | ((page) & 0x1F),
-		 (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
-		  LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F) */
+
+		/*
+		 * LCD_PAGE_ADDRESS | ((page) & 0x1F),
+		 * (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
+		 *  LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F)
+		 */
 		write_reg(par, 0x00);
-		/* LCD_PAGE_ADDRESS | ((page) & 0x1F),
-		 (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
-		  LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F) */
+
+		/*
+		 * LCD_PAGE_ADDRESS | ((page) & 0x1F),
+		 * (((col)+SHIFT_ADDR_NORMAL) & 0x0F),
+		 * LCD_COL_ADDRESS | ((((col)+SHIFT_ADDR_NORMAL)>>4) & 0x0F)
+		 */
 		write_reg(par, LCD_COL_ADDRESS);
 		gpio_set_value(par->gpio.dc, 1);
 		ret = par->fbtftops.write(par, par->txbuf.buf, WIDTH);
-- 
1.9.1

Re: [PATCH] Coding style cleanup

[Dan Carpenter]

Fix the subject line.

On Mon, Dec 14, 2015 at 06:09:46PM +0000, Ben Gilbert wrote:
> Fixed commenting style warnings.

This stuff is dead code.  Just delete it.

regards,
dan carpenter

Re: [PATCH] Coding style cleanup

[Ben Gilbert]

On 14/12/15 18:17, Dan Carpenter wrote:
> Fix the subject line.
>
> On Mon, Dec 14, 2015 at 06:09:46PM +0000, Ben Gilbert wrote:
>> Fixed commenting style warnings.
>
> This stuff is dead code.  Just delete it.

Thanks Dan. Please ignore this patch, I am sending a new one.
>
> regards,
> dan carpenter
>
>