From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753391AbbLNT4M (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Dec 2015 14:56:12 -0500
Received: from mail-pa0-f45.google.com ([209.85.220.45]:34261 "EHLO
	mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752799AbbLNT4K (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Dec 2015 14:56:10 -0500
Message-ID: <566F1ECB.8080809@gmail.com>
Date: Mon, 14 Dec 2015 11:55:55 -0800
From: Florian Fainelli <f.fainelli@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>, computersforpeace@gmail.com,
        gregory.0xf0@gmail.com, linux-arm-kernel@lists.infradead.org
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] brcmstb_gisb: Replace "hweight_long(mask) != 1"
 with "!is_power_of_2(mask)"
References: <1449396705-14235-1-git-send-email-zhaoxiu.zeng@gmail.com>
In-Reply-To: <1449396705-14235-1-git-send-email-zhaoxiu.zeng@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/12/15 02:11, Zhaoxiu Zeng wrote:
> From: Zeng Zhaoxiu <zhaoxiu.zeng@gmail.com>

is_power_of_2, AFAICT does not handle the case where the mask to be
tested for is zero, which is why I went with hweight_long() in the first
place.

Without further explanation as to whether we should prefer
is_power_of_2(), NAK.

> 
> Signed-off-by: Zeng Zhaoxiu <zhaoxiu.zeng@gmail.com>
> ---
>  drivers/bus/brcmstb_gisb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
> index f364fa4..2816a04 100644
> --- a/drivers/bus/brcmstb_gisb.c
> +++ b/drivers/bus/brcmstb_gisb.c
> @@ -24,6 +24,7 @@
>  #include <linux/of.h>
>  #include <linux/bitops.h>
>  #include <linux/pm.h>
> +#include <linux/log2.h>
>  
>  #ifdef CONFIG_ARM
>  #include <asm/bug.h>
> @@ -171,7 +172,7 @@ brcmstb_gisb_master_to_str(struct brcmstb_gisb_arb_device *gdev,
>  {
>  	u32 mask = gdev->valid_mask & masters;
>  
> -	if (hweight_long(mask) != 1)
> +	if (!is_power_of_2(mask))
>  		return NULL;
>  
>  	return gdev->master_names[ffs(mask) - 1];
> 


-- 
Florian