From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753617AbbLNVR5 (ORCPT ); Mon, 14 Dec 2015 16:17:57 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38414 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753584AbbLNVRy (ORCPT ); Mon, 14 Dec 2015 16:17:54 -0500 Subject: Re: [PATCH 0/3] cpuidle: avoid module usage in non-modular code To: Paul Gortmaker , linux-kernel@vger.kernel.org References: <1450051032-32329-1-git-send-email-paul.gortmaker@windriver.com> Cc: Alexander Shiyan , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Kukjin Kim , "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org From: Daniel Lezcano Message-ID: <566F3203.5010009@linaro.org> Date: Mon, 14 Dec 2015 22:17:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1450051032-32329-1-git-send-email-paul.gortmaker@windriver.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/2015 12:57 AM, Paul Gortmaker wrote: > This series of commits is a part of a larger project to ensure > people don't reference modular support functions in non-modular > code. Overall there was roughly 5k lines of dead code in the > kernel due to this. So far we've fixed several areas, like tty, > x86, net, ... and we continue to work on other areas. > > There are several reasons to not use module support for code that > can never be built as a module, but the big ones are: > > (1) it is easy to accidentally code up unused module_exit and remove code > (2) it can be misleading when reading the source, thinking it can be > modular when the Makefile and/or Kconfig prohibit it > (3) it requires the include of the module.h header file which in turn > includes nearly everything else. > > Fortunately for cpuidle, the changes are largely trivial and change > zero runtime. All the changes here just remap the modular functions > onto the non-modular ones that they would be remapped onto anyway. > > Changes are against linux-next and compile tested on ARM allmodconfig. > I've Cc'd ARM list because all of these are used on ARM, but I'm > thinking these probably can go in via the PM tree. Acked-by: Daniel Lezcano -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog