From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
dvyukov@google.com, yanmin_zhang@linux.intel.com
Subject: Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement
Date: Tue, 15 Dec 2015 13:43:07 +0800 [thread overview]
Message-ID: <566FA86B.6060408@linux.vnet.ibm.com> (raw)
In-Reply-To: <20151214185513.GA19131@kroah.com>
Hi, Greg
This patch is dropped, I have created another patch based on Jiri' patch.
On 2015/12/15 02:55, Greg Kroah-Hartman wrote:
> On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote:
>> From: xinhui <xinhui@linux.vnet.ibm.com>
>>
>> If gsm driver fails to activate one mux, and this mux is not stored in
>> gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this
>> is a legal case. So just do a simple check instead of WARN_ON.
>>
>> There is one filed gsm->num to store its index of gsm_mux[]. So use
>> gsm->num to remove itself from gsm_mux[] instead of the for-loop
>> traverse.
>>
>> Reported-by: Dmitry Vyukov <dvyukov@google.com>
>> Fixes: 5a64096700dc ("tty/n_gsm.c: fix a memory leak in gsmld_open")
>> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
>
> the signed-off-by name has to match your from: name :(
>
prev parent reply other threads:[~2015-12-15 5:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 11:18 [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement xinhui
2015-11-25 11:27 ` xinhui
2015-12-14 18:55 ` Greg Kroah-Hartman
2015-12-15 5:43 ` Pan Xinhui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566FA86B.6060408@linux.vnet.ibm.com \
--to=xinhui.pan@linux.vnet.ibm.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox