From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933272AbbLOJKG (ORCPT ); Tue, 15 Dec 2015 04:10:06 -0500 Received: from mail-am1on0053.outbound.protection.outlook.com ([157.56.112.53]:24832 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932219AbbLOJJ5 (ORCPT ); Tue, 15 Dec 2015 04:09:57 -0500 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Subject: Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port To: Andrzej Hajda References: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> CC: Jack Morgenstein , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "David S. Miller" , Eran Ben Elisha , Hadar Hen Zion , Moni Shoua , Yishai Hadas , Maor Gottlieb , , From: Or Gerlitz Message-ID: <566FD8D4.5030506@mellanox.com> Date: Tue, 15 Dec 2015 11:09:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.129.55] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11FD005;1:jOHd6vnBQmyMnJwa5deusgw1PWkKBJ5mH3QHX3XhOyYt+vT02ocTHYc8x3GilQhp7EfH2XfG/7nhvGXSPxo+OflEOaws5vRoAeFCQui/gP5bBqm/HIJJXg1YPcTQWynC2FbVMt1IjdNfLqzDT1r5nQM1MvrkYT289m6mKxzpJXoSqCJ/AVMkMitfvI2GWwULFvsXP9CGq4QN6s69KUDhJMyf81OsNLSchc0a5Naz3X4FUdggI0kB9AfYn6LWTHN2bepyyKk8Jxu9VLOdrVMIaALV7LUsnYSOYVEn1MUYN1tml+MCqrVwuTz+sJhX6OLeN3F/AIxY082JLq4JxlVYmWRvxFmGVq9qeaEnWerhhveOia4awPzWY8w5vQvnBO3CERUmuHc6BXqxU33kkV1Mz/lImrQRS3MUSZi2h0UvPqw= X-Forefront-Antispam-Report: CIP:193.47.165.134;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(479174004)(199003)(24454002)(189002)(377454003)(586003)(36756003)(33656002)(23746002)(59896002)(1096002)(5004730100002)(15975445007)(65816999)(77096005)(230700001)(6806005)(92566002)(2950100001)(64126003)(80316001)(3846002)(106466001)(6116002)(50986999)(65956001)(83506001)(5008740100001)(1220700001)(50466002)(97736004)(86362001)(189998001)(54356999)(19580405001)(4001350100001)(65806001)(19580395003)(47776003)(110136002)(76176999)(87266999)(87936001)(11100500001)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR05MB531;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:ErrorRetry;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM3PR05MB531;2:XWwh4yDWhrqT7cDAg1zdtsSWveAIVZ7Xwp8dK1nOo68MMQCtHzYDivsP7zbIqlcvy5JGeMsm7guMxOyrE/jdGowzlSxsy5HsjnFnZokJpCJosVJtRGa7xte2g1Wg6cWx7QsaDuqbw/TZo1WVefIWug==;3:TLRuN76h6iC/63GvlbZjsMY4LqplgufemX2Tbbmo3PqO+kNSHEGqwve2qxs8VomORnHfaiC8SpOBoCFEXpFLBK3hnKD6RgydAh5Yf1DSQ5UIl8bcmG4T05Wjb5hXhJw1tFMYp0ynkwFAUhAlr4+1szNAAgeCAL9TGTUbdfUpk9N+FLRKy42vHYvZeYtFkkd6FMD3K66nL8G7lIBb2N8RvJDovGEReUS6XxGxOpOaXesS6a5hKLh/d3vjV+pXao7poWC37gG0PwYyt0KQAtU9aQ==;25:q1281HiVCPl7FehdsNfU1QqX5QTwfCsyzXqpzK3o5kQNXnYFwSBfr3W25gmZ51QUVUJQ52K3heO/apfQyG1Kq99zTxMZhgXRRYPq5nak+dItPaHSZX/UoU1PLLQdRsJy13dU7aLqBzvwz8g8gjvgMDibU+Ql4ZJW6HAOmWBTRvFcI47cIqAHHsP3yoOFKF2fdRsUwbSuaoluyoHOLUS3xDHiVWlJWi/mzyGtjRfc4wNlyO9QW3xHs91MZJfq691uMQJuID0KFh3rWDW//irhCw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:AM3PR05MB531; X-Microsoft-Exchange-Diagnostics: 1;AM3PR05MB531;20:/hGXjaI+hYBOcuGWVCZvQLDx3bnNZzmLZUBzrfywjsi47Qt5rFovIt4kVaJ7ISE/W2kf4XMzy0R9QZK1yfHHgljabVSGT45BTeNRFDt5t0U5WXLfNVRigmY8+VeL0+RmyOKI9dTvDlxplhzUFt65az1wMIx3dIhO+N4/obAhWXIyBYrOgxF9mEvjI7OdGxSCqvdY0JW4Ck6RfErsH9VUeiIqYIBNcjT4dN1WzAUw2lRy6wRNxKzcPp99+L3vsc/5im3qUG53jdiN2punmaFlqsh4H4BOJSPTjcee/VnKtLfQzprBwBWT6gbhSbgG70PVrl/H+XVXB5X4OHXA9Fas9dx+vuQzOvyZCJoEx1h0DBhQI8JwuvyewxqGBh5Ig/KFiH9CjklYjdaAfBCsuWsPbz73nboaiHqIN0+P6eMTqiaV75upi8oSDk/ysKqzyVMzgBDcPq0B5uGmj6Ghl6ivDMZes1fN2uXwp2lJ8p3dA5ODNOXK6VaWZyW7jOeGRVe1;4:ubGK3qYcii32bVxAxRLTAs4iOWJH0a3btjWUYfw6kgXoH/269xe0+MMSDJIWg+8j2f9JqfdYrVOIpeu+UwQ97h1vGtY6h9Qkk/l8f73GEAx1IDgz984gZ23gYzEm5QKbEThkyN4U78TvIpZFrMYJtc04i2l2Vcrx/97PGgtKk4wiq6uVAJrY1/wv0aw3QKNlqslFuRCEjRjrocinQJ3wIcETIiMxLpfexeFRDJOb0TKtSBro3cERbw8k9cIzKLiHiccSIIEUny8uSZKlr4j1cr83ExZF7HNI/z4qms5WFQHPKMm1W2cs1HzIta67KTj8SIhMDFDjzJYGCS5hh1AuxC8Q+GE6XBKpOIn7FWDjbh053MjvaHIGWszVNbvBp0e5zjsglucwj7W/G3MuwKFGfptaN02oM6USSS8g8sHMQ/YJNV7/fKcPvxImhUaWYvOe X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(34787635062028); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:AM3PR05MB531;BCL:0;PCL:0;RULEID:;SRVR:AM3PR05MB531; X-Forefront-PRVS: 07915F544A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM3PR05MB531;23:wdjDsX9tONcQ8ilJm6A0lw/GRIX2Yx9GCZU2eu?= =?Windows-1252?Q?6yMw9c6dAo1Uo1hwixQpaHgUHH64tcR0cKyZ1LJzWduSt0A8M/UieLZ3?= =?Windows-1252?Q?h26ZxzwIl3AEdCJSD04yOz7OI28t6FXsy6mVmlBbvpkNfAZWbwZANqH/?= =?Windows-1252?Q?Pu+XzqJzL+McIap6XbuMtdm5NnRrsfs06oUOUICsupyuA3mRXmWN2vGb?= =?Windows-1252?Q?j0Bhq8pe0CWTXwVTOKVXe1UcGMcjRPZcyHXZ+oDrX0oXdncqlxyFPGhv?= =?Windows-1252?Q?XHEMcegAvgG7l7wVjpofzh+NMtKqiKyMHzE8Ox9qOfLkhzpwNFEmWZhR?= =?Windows-1252?Q?3+GLdOYoiQgykXQ5jxFSWvtnu4/SnHmYq6r1IuWwcPhLV1Aus83FHuQq?= =?Windows-1252?Q?1ciIYwDgKw/0InKf1L5TEAUhJGpks1c/gyO939sdOeX1gP2chvp7coYZ?= =?Windows-1252?Q?h3bMCl+iBiRZF902tjQ3rDLF8DrKhABpW+fAXtsQFF6OsK2rk90DNk7N?= =?Windows-1252?Q?UkE78hpHK4loJD35OJR8AUQfVtOa0GxTPNIYG6qYoslAnzqdE7Hjjwp5?= =?Windows-1252?Q?jd79+IcXM9lwmQvXX9640txa0xIf7OYIqLw9NHpmdaXM+cCDRMv/jl+9?= =?Windows-1252?Q?mHqUEBkR3I0L4a6VKfaOXVQ32O51LW87hENNrCsJumsF87PYTdey1UrF?= =?Windows-1252?Q?mey48kqHNAdTAtok0eVU4th2a1wZ1aayuoRF83dkwiYf/FD3fc6ni5xG?= =?Windows-1252?Q?iMq8szj6HSgOmnB92scYgKVBmchN/i9jRHToNyU5nGixQhM8uzO9vAFK?= =?Windows-1252?Q?CDh57WraGf/eZh148ARG+GRRrrI97+OCuNBYaRNZgotxMQDcTEwrkNE7?= =?Windows-1252?Q?7rV2cDGIpQ4G3H5tnVgVoKQqaRNdgDzoYBcKQfURemYIiEHKT/fUM4Mm?= =?Windows-1252?Q?tR6jM5QYm6rCOkxzvGm1DSKU/8n8YWv8tS5jsJYf1MNPl0658yNiXY7o?= =?Windows-1252?Q?ko5K8kgqsBDhUuDiG4xeSH+ZK5DTrkZdlGdzF7irAWneMnIQOiQ9XBY5?= =?Windows-1252?Q?wvMMUASxAOva+2JmSqi2V5E1TRHT1ZdFkNffYMPostNNO+G5W0BJNJhr?= =?Windows-1252?Q?PgWz9Li55e7VHEn5AWsTm0gOMeLtOQmCRg1Kr7ceALI/G+3QtcMDFYqc?= =?Windows-1252?Q?ycU+fSoeTqGRWVi6fLrG5GAjkueNHJ7SY7w8qsDzObQ7lSWbdUQyGn3P?= =?Windows-1252?Q?E1jBxuhsW5s0Bf5fN0aDg3y7G24nJmr+lb7iz5CwRP4Q4+CGlEQXMPci?= =?Windows-1252?Q?ivWzVtz4dcqSaQSIus36EhDhsUqca3Z4sdf9+145MkGI8=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR05MB531;5:nSnzgYs0bE8TbAYn+TRFZ2AjyISzJ77RWgrffApPu8qVN8hvPgtZtVyzW0MED71tkZ8HKldkmjI+J/BQvL5fTPQoxZ/KA2SCVW7x0Ge0/uqgKtC4lQFTpC8tMyzbonLQ4xGF1OQHqQCdcgt5CFEpJQ==;24:uvQW5IUJGCKnKuf3ZuZ+I5ZkXputNgl9UKqJ2bIpOWsGe+WpR7n8ytmBolRmbjqFCroFLl1qzgUwYWDaUoImWZcp0xBKlajko2qxOEJfHVQ= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2015 09:09:46.5716 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR05MB531 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/2015 12:05 PM, Andrzej Hajda wrote: > The function can return negative values, so its result should > be assigned to signed variable. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > Please add here Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF') > Signed-off-by: Andrzej Hajda otherwise, Looks good Acked-by: Or Gerlitz Or.