From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965094AbbLOLPP (ORCPT ); Tue, 15 Dec 2015 06:15:15 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:45014 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964960AbbLOLPM (ORCPT ); Tue, 15 Dec 2015 06:15:12 -0500 Subject: Re: [PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg To: Arnd Bergmann References: <1450170968-11282-1-git-send-email-kishon@ti.com> <725110094.6UkMkcy8u7@wuerfel> CC: , , , , , , , , , , , , , From: Kishon Vijay Abraham I Message-ID: <566FF621.2040307@ti.com> Date: Tue, 15 Dec 2015 16:44:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <725110094.6UkMkcy8u7@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Tuesday 15 December 2015 04:26 PM, Arnd Bergmann wrote: > On Tuesday 15 December 2015 14:45:59 Kishon Vijay Abraham I wrote: >> This series is basically to deprecate using phy-omap-control and use >> syscon APIs to program the control module registers. >> >> Changes from v2: >> No changes. >> >> Changes from v1: >> *) cleanup ti_pipe3_probe in multiple steps >> *) other minor cleanups >> >> Changes from [1] in PHY patches include >> *) cleanup ti_pipe3_probe >> *) have mask, power_on and power_off values in usb_phy_data for >> omap-usb2 phy >> >> The patches have been pushed to >> git://git.ti.com/linux-phy/linux-phy.git syscon >> >> [1] -> https://lkml.org/lkml/2015/6/23/189 >> >> All the testing was done both before applying the dt patches and after >> applying the dt patches (dt patches will be posted shortly). >> > > Can you explain here what the conversion is good for? Why do you > prefer the syscon mapping over a high-level driver in this case? phy-omap-control driver was added when there was no proper infrastructure for doing control module initializations. The phy-omap-control driver is not an 'actual' PHY driver and it was just a hack to do PHY related control module initializations. phy-omap-control is also getting unmanageable with the number of platforms each having number of modules (like USB, SATA, PCIe), using the same driver for control module initializations. Now with SYSCON framework being added to the kernel, phy-omap-control shouldn't be needed and it also provides a uniform API across all the modules to program the control module. Thanks Kishon