From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965093AbbLOLhx (ORCPT ); Tue, 15 Dec 2015 06:37:53 -0500 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:36653 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964944AbbLOLhv convert rfc822-to-8bit (ORCPT ); Tue, 15 Dec 2015 06:37:51 -0500 Subject: Re: [RFC PATCH v3 4/8] arm64: Handle early CPU boot failures To: References: <1449655039-22022-1-git-send-email-suzuki.poulose@arm.com> <1449655039-22022-5-git-send-email-suzuki.poulose@arm.com> CC: , , , , , James Morse From: "Suzuki K. Poulose" Message-ID: <566FFB87.9030208@arm.com> Date: Tue, 15 Dec 2015 11:37:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1449655039-22022-5-git-send-email-suzuki.poulose@arm.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD017;1:JNgaKaw0AkPHAv7dyPSu9PRsMt45VCcqV95FEmmFcBlc7L3GeAhb/7OD4UZTUaPpKN4XMfTJFAif02fZ4yC+oOrwBKo7iMkT80BAqemVQASE9oGE/70kWTLbvhpo6TG2RggQziqXtL7L6ZGsUjgek4HutTEYhjVGzW+VjhcfhPiRxrwENmpTlRbGzkw+Eu2KA5wshJJlLXuiMVP1Yf38vlYeTCP2cY/Hlr5SaTx1E0FOTXGedAexe5DIjhOrpc6qwEOqQNKhXmdAlrEl5bAlX1CiGqzKuGcsZWdNk89nUQ2VdQeqWneq9csaiYMngQQFopvnZn+v3eR5aY0LW/UhzMQAbzIXs3XTviNREUWeAYfffIOwP58+QlEbRwbap6gI9MvJjpzFXq9fmwQ6fuvQDw== X-Forefront-Antispam-Report: CIP:217.140.96.140;CTRY:GB;IPV:CAL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(479174004)(199003)(24454002)(189002)(40434004)(1220700001)(2950100001)(86362001)(92566002)(87936001)(2351001)(33656002)(65806001)(65956001)(4001350100001)(5890100001)(80316001)(59896002)(50466002)(64126003)(26826002)(586003)(65816999)(47776003)(77096005)(83506001)(104016004)(76176999)(87266999)(1096002)(36756003)(23726003)(6806005)(5008740100001)(110136002)(54356999)(50986999)(106466001)(189998001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR08MB0888;H:nebula.arm.com;FPR:;SPF:Pass;PTR:fw-tnat.cambridge.arm.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0888;2:oCfpcCeTI1pgCGIc935eB5jYFo5Pu4davFdNmdXsSqcUuWy7ryaes0iz+zRlOJ95dpbZPsSTrjb8Qug+vvQNJApdd9sodQxRwCKtaDHZxX87EewPrZHL+Fi0n4O/XBTwsQxxFduQCU1w2uQ6JHOdIg==;3:gqSlZl4MPTigYBLBxIIsO+w6GPCgykOdciBmTwgHKOeDy1ZQlRqCM2JJkt+xGAuUbD5QSJJbK/AIo+mSG3MrzXgCBgCz4kbIoKcalF9G8oJ8b7IkRUR5aUqha/onPAWKObo+1NPTAR07NH6UJlH4t1ATltw2YDih4seHC+dxScYsW6e1L6O4fiIVFNDhZBhd54L4mtmelCnoyIWXAsnDTYNjMpimrs9b/kBXQj7SF0/obhxZllsPuH5CAcbMVMdRZSslle15huXli4HJDsxzjQ==;25:uHDyq3aXIEV9TnFT+l7xdJJ2bC5BSrBoZK6++kkJKVeV1its6Td7F7nKeRgAuwMdDmTspLYqNHORpg/QcYxkf3VXBfwMyyirfhyqIqkbqjCaFL1j4vkMC1jGXGnp3dS2jErFfXJMlxoy9bZr5UbE4gyfWgndAhKTjWEr2bfsZ89t0EOAUeDHw37DKEstpeVUuBhgrDJC7O1GEgoGNCMEvYikR4TLh4L1aYAAsxKVDGyHGhJvljJx8U0ALUgGZ6NB8FFRYR0uvtU0u4JJ+sRJDg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DB5PR08MB0888; X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0888;20:Cceb/fpW7cNKPbl75rTjLKdE/mRoNyaJyAmB7HmSvO5X+olj4xLtwU5wpu6ri5M3rJ3C3FOYkXO0Vli1t01cPn3BE/6XEG7ksu1/JqzO131nT0YIvq4hek7hVUsO/1ctulDYYUhYYUj1DYQPj1ox3vhtJo6YijMY7NAOHCSttFM+EfGkHPGINMCBvNd9OO3Gdw9Z2LEGDx5/MIL3KkgemkZdTzTTCcozHncuD/3HwRJjJP9eseRJCMDq+oLH8NBS;4:/e2YfTphtQjo+NsOuMs0jPCO2WBaaC0TPEbDO1a/xjI5mmC/MSmGB/AcbOg90/zR45FsC3/bu0setd3o8xj3ShB128fVgaaUTVSOAaQbOOc+vW5ufb9XUbR2rLrg7z5Hy/t5KqHl7hRdfUmCGojFsDsuy4rO5wnw7hvBzo7k3ERWI5JL9XU8UnOiWVPCYDbo+YjrkNV+eqNDqlD5mq43DVEizQcbtWvrO64wr5CxotEiV/OVY+hp/0nTMPpA8Of/3/W7tKasW8NZ1sZd9iyVOt11Na5iOXofBlXQ2/m+rsVGL3C9+P67SMt7EQcBlGtM+GCCjy+/+Gv7BaS8/rPJbIZ9vkFqwW5rAcJV8O3QRNNq/C12K0vgXZU27BfYwhjT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:DB5PR08MB0888;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0888; X-Forefront-PRVS: 07915F544A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB5PR08MB0888;23:DYF6B4CaTQeBWGqyYwKc1J8AZU5GHgN7wjX+E9Az2?= =?us-ascii?Q?Aq74+yPwx8fWM+hOJF9cpQrotXVDpfjWJM7FvFpws/B0+jpHAZvZ/yojd42E?= =?us-ascii?Q?9ZL9c4cQ5aCNvvPRM2OaQ7clLBaCNOpzD64z9IV1IBEufKjNZF7I819lZDJY?= =?us-ascii?Q?6qIBoD4kCH8GWOlKs9dvzLdOa6k/iu4Fve1fCQJg1A8Fpfx2dcnaKo9+0HTu?= =?us-ascii?Q?6bepL8WkmY4XXN0WK1u0gWZnrJhNZvaqvdNkJBqjzWl/IVDA8kkHpd60Cd7J?= =?us-ascii?Q?+iQAu1LMYAgcsQi1dainDf4AG34oWz7EPZ7iUI1w9HlohIfK6sBzBfJupGv4?= =?us-ascii?Q?FhyqUDwSFkuW4sNtYefoHkdCEw5yAhVTVf69fzo9g10Zc73wGWY5yZaFU6F4?= =?us-ascii?Q?FTLKUr3LXUCuz/tOgBMAnSE45nqiYYDlUEdyEPgPbARSKaQcA8Tgl51VwOLd?= =?us-ascii?Q?igZ+QJUPmTMZ6/8coaBVjVHyBWY4wx44sQrmCjRgbRnlP12tw63XOmzjfENo?= =?us-ascii?Q?pvi1dxEm2IOBYz38E3wSMhivSiLm+v9oE/elraUd/Tz4ycYarLOBS2lh6Tgi?= =?us-ascii?Q?kIYfatFlsoPwfvPxsCpzW/zB93vEIVHjdQfNzgSZTCZW06XFNTc00XDQlBi0?= =?us-ascii?Q?NUykrJb+CcP/mIkTzTvLmFJrqEQhZZfFyJTp8u8MrTgxlDaAwbCBTcoqg7vt?= =?us-ascii?Q?hbDzaV4Fjsx+VCzEBRqG4XZ2Mk1hZx8xggrVHycIgQEqJ/y6+s14qc/rKaqB?= =?us-ascii?Q?moGhe8nsJdUDvJId7aXTGT7vM7KDWoIQb8Ytp6B9f6YHAv0TjmyF5XnCskaG?= =?us-ascii?Q?bOxRXBF90z0XqfX1WBDaUz1TftdrpqalLWMG29uZI5NhmHpgogyHauBoyR8B?= =?us-ascii?Q?vGJuRscTXJjYyZmkQinOfps44GRVhS22Ehr7rtp1L7aVbG+NiGQ1qaidcHj9?= =?us-ascii?Q?zJHh98P5NW+Tbjxh7h1fv/YLjxjAFD5GYsZYQP7t/5slaFwdQMWxcXGEFpfO?= =?us-ascii?Q?rC6sxl1fQFW/tz2rtBUQonYmKPZt4pROvISJq9207hv8J+1fzT9iGdfQe1CC?= =?us-ascii?Q?19le6YJWlkWHl6VL4QsDbu6KGvRoRkaLagQT8W0SiEeoUvAdA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0888;5:jmhA0cnVtxvC+YstHD2C/EEUnC+c3Loh0uX4LqKvuE60AIOeBMdZImIGIC1en5cSuPbmHicTEbKRKIH0GWT22ZiXOFgsJuxkk3Rfm9OLlllMov1yDecBd6S8p5w7qIhhI1FEdrNs2GqYd2kJx345xg==;24:XB6m8brflvhbuCKVVME7hbdH7Jmxgf6HqjrFL+mYnuRI5QVRJwFqKx1aigHo1r2o0SNDbedGAybgtHbR2LOQxWtq4Sc9c1ddkcAuAeZv/tQ=;20:4jCF6++OvdvpkpN62Vy7M0SpQ6UiA5R8R94eIHmegsjpI7Jw/EWLcXX2lEZc1l+OzzFdUkz3syscQGTvfWWy3b8G4NH+ZqCWg+rnQh8zlWvHrDsTuMkwfQuo0QTIdtMEnzfM4p8q7wPL9hujX9VjuT2x5j0ZvmVzN6twttn5PJc= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2015 11:37:45.4426 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0888 X-MC-Unique: SP9wuvW-RfCukaW5K40zGQ-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/15 09:57, Suzuki K. Poulose wrote: > A secondary CPU could fail to come online due to insufficient > capabilities and could simply die or loop in the kernel. > e.g, a CPU with no support for the selected kernel PAGE_SIZE > loops in kernel with MMU turned off. > or a hotplugged CPU which doesn't have one of the advertised > system capability will die during the activation. > #ifdef CONFIG_HOTPLUG_CPU > + update_cpu_boot_status(CPU_KILL_ME); > /* Check if we can park ourselves */ > if (cpu_ops[cpu] && cpu_ops[cpu]->cpu_die) > cpu_ops[cpu]->cpu_die(cpu); > #endif > + update_cpu_boot_status(CPU_STUCK_IN_KERNEL); > + __flush_dcache_area(&secondary_data, sizeof(secondary_data)); James pointed out that we don't need the explicit ___flush_dcache_area (which is a left over from previous version). I have fixed this locally. Thanks Suzuki IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.