From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Gur Stavi <gur.stavi@huawei.com>
Cc: <andrew+netdev@lunn.ch>, <cai.huoqing@linux.dev>,
<corbet@lwn.net>, <davem@davemloft.net>, <edumazet@google.com>,
<gongfan1@huawei.com>, <guoxin09@huawei.com>,
<helgaas@kernel.org>, <horms@kernel.org>, <kuba@kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<luosifu@huawei.com>, <meny.yossefi@huawei.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<shenchenyang1@hisilicon.com>, <shijing34@huawei.com>,
<sumang@marvell.com>, <wulike1@huawei.com>,
<zhoushuai28@huawei.com>
Subject: Re: [PATCH net-next v04 1/1] hinic3: module initialization and tx/rx logic
Date: Wed, 22 Jan 2025 14:58:31 +0100 [thread overview]
Message-ID: <566b3d82-5e66-4e97-9808-a0e8e212fe67@intel.com> (raw)
In-Reply-To: <20250122070752.3966233-1-gur.stavi@huawei.com>
On 1/22/25 08:07, Gur Stavi wrote:
>>> Auxiliary driver registration.
>>> Net device_ops registration but open/stop are empty stubs.
>>> tx/rx logic.
>>
>> Take care for spelling: Tx/Rx; HW (just below).
>
> Please elaborate. Spelling of what?
In all code comments and commit messages the acronyms and abbreviations
have their proper spelling, like "Tx", "Rx", "HW', "SW", "ID".
of course lowercase names are still allowed for variables/fields
>
>>
>>>
>>> All major data structures of the driver are fully introduced with the
>>> code that uses them but without their initialization code that requires
>>> management interface with the hw.
next prev parent reply other threads:[~2025-01-22 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 7:51 [PATCH net-next v04 0/1] net: hinic3: Add a driver for Huawei 3rd gen NIC Gur Stavi
2025-01-16 7:51 ` [PATCH net-next v04 1/1] hinic3: module initialization and tx/rx logic Gur Stavi
2025-01-16 9:36 ` Przemek Kitszel
2025-01-22 7:07 ` Gur Stavi
2025-01-22 13:58 ` Przemek Kitszel [this message]
2025-01-23 8:20 ` Gur Stavi
2025-01-23 9:32 ` Przemek Kitszel
2025-01-16 18:10 ` Simon Horman
2025-01-21 9:47 ` Gur Stavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566b3d82-5e66-4e97-9808-a0e8e212fe67@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=cai.huoqing@linux.dev \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=helgaas@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=meny.yossefi@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=sumang@marvell.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox