From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965486AbbLOWEI (ORCPT ); Tue, 15 Dec 2015 17:04:08 -0500 Received: from mail113-251.mail.alibaba.com ([205.204.113.251]:32933 "EHLO us-alimail-mta2.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752144AbbLOWEF (ORCPT ); Tue, 15 Dec 2015 17:04:05 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1089868|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03271;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=5;RT=5;SR=0;TI=SMTPD_----4LtmRCH_1450216992; Message-ID: <56708ED4.30403@emindsoft.com.cn> Date: Wed, 16 Dec 2015 06:06:12 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joe Perches , Arnd Bergmann , trivial@kernel.org CC: Linux-Arch , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH trivial] include: asm-generic: Notice about 80 columns in pgtable-no*.h References: <56702088.9080605@emindsoft.com.cn> <1450211204.4142.30.camel@perches.com> In-Reply-To: <1450211204.4142.30.camel@perches.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/16/15 04:26, Joe Perches wrote: > On Tue, 2015-12-15 at 22:15 +0800, Chen Gang wrote: >> It is a trivial patch. > [] >> diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h > [] >> @@ -38,7 +38,8 @@ static inline void pud_clear(pud_t *pud) { } >> * (pmds are folded into puds so this doesn't get actually called, >> * but the define is needed for a generic inline function.) >> */ >> -#define set_pud(pudptr, pudval) set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval }) >> +#define set_pud(pudptr, pudval) (set_pmd((pmd_t *)(pudptr), \ >> + (pmd_t) { pudval })) > > Not quite so trivial. > > If you _really_ want to break this up for 80 columns, > and I don't think it's necessary, it might be better > to use something like: > > #define set_pud(pudptr, pudval) \ > set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval }) > OK, thanks. For me, it is better. -- Chen Gang (陈刚) Open, share, and attitude like air, water, and life which God blessed