From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965686AbbLPCPN (ORCPT ); Tue, 15 Dec 2015 21:15:13 -0500 Received: from mail-by2on0091.outbound.protection.outlook.com ([207.46.100.91]:51522 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932602AbbLPCPG (ORCPT ); Tue, 15 Dec 2015 21:15:06 -0500 X-Greylist: delayed 90391 seconds by postgrey-1.27 at vger.kernel.org; Tue, 15 Dec 2015 21:15:06 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH] i2c: designware: Add support for AMD Seattle I2C To: , References: <1450216553-5641-1-git-send-email-Suravee.Suthikulpanit@amd.com> CC: , , From: Suravee Suthikulpanit Message-ID: <5670C90A.5020305@amd.com> Date: Tue, 15 Dec 2015 20:14:34 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450216553-5641-1-git-send-email-Suravee.Suthikulpanit@amd.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [99.190.132.251] X-ClientProxiedBy: KL1PR02CA0018.apcprd02.prod.outlook.com (25.165.15.28) To BLUPR12MB0433.namprd12.prod.outlook.com (25.162.92.139) X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0433;2:8hfqPUPHGAbk/Xt4dkJtMQBYXgoFZi73D0mEzjaLt0vlIg4XaRvQ2hoObSiMTp5hyO4SQnmEH/j4suDAqvfBpSNh+FdpOmDNPTtJULcskNIW9b/V+XpmDTCr5VxQ4ZnQdns/YJkrN83SeG/mPc8Nfw==;3:CE8Uzpz7ysz6+zTmxE3otmc9TkX3yvDWxLfn2W4DIDfrt4WC7Ofm8DV5ToOn5rD3QUaMJ8OAZUfbSdGBC0n91/+T8kvzGKoIgFrhUKtPV+/M7VAfOgFlqiwQH91jU0+8;25:UXfpp5GLFPDvWs211weWOqe32eTU6P2aVenao3igbR0BjHt5Jouti1zQ57IQfhGzXokQ7zQ7WAIEsUa5ni28BS9CIkWEpBGqNA5Wm9WORwPgAZAvjVvTD95U3XrF32wDcrau1ZBouhTgi9LFP5d+HiCH9wDAvZpi90sT8cIVwJI6jre+fuVb8V7t0eRifVKBMPNc5rwq+sDuBgwQmthT4ayQpd4+ZHxHnL6ZDmodxiaFolAXGYUpiGkNcpMr3iouGYVmU5CQSPNc/0s2sW7z3g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0433; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0433;20:tLD3hTvUvr2A7iejR3FJyEjv8oy75Z7dqOTIRvUrK/0UNUtb37v8Razbm0eHNb07ZvJeBAJtMq4dJUo/vf33BDbEmBUk3DNKZNMcLfyPUBBEoR+u57aClSeWBUg1LVO5WmtfYE+VyfwvK/1GX1phcKG6/DJJ2QEP01Y2pCc8bMtvMbnCkNW2akStB9ebqGn4P/+Wg884iHBYaEiznPPrAR0HIT8bsTvEcsn+3kbB7XVe6poNGKDsJWHs57/44b+AIXo5B0Lt2cNFkswCaXeoupxsS73Wi45YLCoklH+OzpRPf8IKLcEcDll23L2pGPYDMjoBz4GmES+MpoDyjt/5EWyRLu1QqjUISGdmQAqOIOPKmjal+GgTvhMdYPMq86nOADWljYhEQ0a/5lnadku2oG98GA2mTLxGbYyh+zuSvV0g6Q32sV+hkRmZrLv6STqUpHukibFhU/JDl5Z+ZXHMrTet397P0IDo9biF83gRmXk24t5pIGrkiuaVABEOID07;4:ZzdVH25LjR936HmEhr49zoo0ujsrT5apPjA8aIxnFSJChpYLZeBg0R6tyXZmJxoK3dnuLZHmMIgOZzPLEdclX30AT0Diu74HGgYQIiHBL1nfbZqs5jZJbVoFxzTIO+aGfc3dz25Llffv0bwXd/8dj/3JX2hknLKzD2C+mkSFzAXkMAuI6WR6iKUZdXW4Qe9UYbxotRTeK8LoPOOyb7f6cwD+rA7LjLY9dcTDhJJULXhKLoy6SirKoLsBEAMo64cwyprhrEgK8evkB9NexZ49frqSkMXwRpn4S5ET7lRZsiu2VDVFAbxwx8spcFstSX3rvdT4nG/RjX3pJzwsQwJLblKGWzpHPNhHeNiqSmSLXH/CikrYI92IfG9H/PJNILzqGVm/mElZgpnAH+9AJbKgQvtIkKhl1FiQgdmHuKJoEPI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(10201501046)(3002001);SRVR:BLUPR12MB0433;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0433; X-Forefront-PRVS: 0792DBEAD0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(24454002)(164054003)(199003)(479174004)(80316001)(54356999)(92566002)(50466002)(2950100001)(77096005)(230700001)(4001350100001)(189998001)(50986999)(3846002)(122386002)(1096002)(87266999)(36756003)(83506001)(19580405001)(23746002)(33656002)(40100003)(19580395003)(6116002)(5008740100001)(586003)(101416001)(76176999)(5001960100002)(87976001)(97736004)(64126003)(81156007)(42186005)(65816999)(65806001)(105586002)(106356001)(65956001)(47776003)(66066001)(86362001)(5001770100001)(59896002)(5004730100002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0433;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR12MB0433;23:5cSTlYb1XAt8X8VkwARuo+z9OxAsFmExFW0ye?= =?Windows-1252?Q?mEkUkhFAoZOH+vd9g0UbbcwgxVlnHukptNCeWITN8o62bdMGjhFaqvVp?= =?Windows-1252?Q?wZlJXM01yD67q2BJYsvnwcDzqySK7R6LYxFMNdHlwioGXbCQsFpk/tK5?= =?Windows-1252?Q?Av+FhSJZ9U/v6yIZX47t+17vfGFM3rBEAtrI4MoBcQlOTYLBJgacrL3D?= =?Windows-1252?Q?CKF48Om/Xx1+kCnucPJlq8Cgt+wxiy2Rgm/UiojdPfjbV/KPOE8UhDID?= =?Windows-1252?Q?yORuIwO1uMWtgIcoRm0tIyd4SW+EWWAMkNHx/uygQFIjg2AijcLu1Aay?= =?Windows-1252?Q?UQA3/eTRQF2gyDWUPSydpDYiY2wWbgbnzoImqnTtGU21jbN/z8Kx/k2P?= =?Windows-1252?Q?guBhn48dIaqkFk44hHMP+DHIuY1wjmqKg+bfQJisNfNocqPOaPgq5ETq?= =?Windows-1252?Q?v7DpKPSX3EaivXcLBfCOL6LIagBBDcPwCtZqj4BwbipyyNN8x4B4veXN?= =?Windows-1252?Q?5ji6ut83rBHrzpN+ROk1mqVtGNsAmwQ9ushCpc2dlxW5D2HIDC/bQk9j?= =?Windows-1252?Q?X/ie+XuYjR9hGxfrNYnBusuyoIUCNeqNXf6GFUeMgqdynSIMw6iRKcWq?= =?Windows-1252?Q?SRRudrsXesK9DdPBdIl6nGTrzslkQhOqr7RtSYmvamVzgRCYImfUpp3w?= =?Windows-1252?Q?evKGHc5uMbqC2VxHCUKc7d+uOH3msUmfWsAkHjnEumd87pPyDVp5tU1J?= =?Windows-1252?Q?lJyM3c+0ouy6zRsIvvEDS9l+EE9NGbj15F2Zmy3Nven36Z1PuUtoCmI7?= =?Windows-1252?Q?P2dKpZUG0Ej+qUES93Ngt3wr9ja0lz5A1QdVHyAD8uIGUFUnAk5GlaSi?= =?Windows-1252?Q?dlE+KLmK6PIsXy8tHP33zid7mh9233hQAArID6m3Ma8lD8FErJWmXbIM?= =?Windows-1252?Q?gac7W1HcXOU+19n6rOeZipeve2bASCqJaKkwD/CNr1qHxpNc9JkGen09?= =?Windows-1252?Q?jjlMCEPYEP6/b4UdaZ102tqEjJKZnXrSKIapISWNcyj4YUJ3aDNO4meK?= =?Windows-1252?Q?1CKickx00pGe9eDlmJg+36J6idaNM+EP02cj2AU6AxPEwDB18N6hgiRp?= =?Windows-1252?Q?WUxSgJ7a0KFNMRaHgfjmsZyWS04kb780ql5d917xM/mQIOeQAZ+lPi5W?= =?Windows-1252?Q?0T/Oe3hA+b5SZIZFKyyvGGg+qvm8vGtV4HmXpW8dPT+oI6vRc6FeQXtK?= =?Windows-1252?Q?nVRwGHrZbKa8vmo29DGFwGuZuNtpaKdXES9CBwZPxwwmevJN7hwjhba7?= =?Windows-1252?Q?onpL41zBlTAEZ3RhEpFmrlj6OVNyi8TuqEETVy8dpt8f0lvfHP3H7Aq6?= =?Windows-1252?Q?Ij56HLAJZJe?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0433;5:79opEN2dy409KJ46rkmVjz9tmGzHIPutm68D6ONw1Zvxr4E06xwV+4HDcjXfShHF1Y7C2xhfT+DHwxl8bUiSIfONGImRRephUD+aejX+2kKCS5kGfvGXUllTKU3EitAWFos/KEY1h3uX5g+cZgmZ3g==;24:qp2+Kzs1hcXIPI0VRohO+jjK8wZWGQ95Hm8ZwAVDWEXSj02nJVFaLkXt/3olEcRKLQqqm0U4TJRWcm7NJPdjxlFbj3MV0yLwQa4cmiAn4aU=;20:f5xb2lAuKw9tC0om4htp+tO2ZV8xAfrjI+hpQXmxsVhMZn54eIDGHB3C2XtHHHtPe33hxaVxx4B/jCFMZjfgFUOmMWNxCFqf9l0laNh3TIEUaV0XNl0RQYWyvOwipRe5B63LIcUnHQdVHyP3yY6fsxLn8p3wxREdnL6p5frwNfz0HrjpkPbO92Cy7EyqrlkHJDnK2C2A6PM3pCd7wOJnP7kdQEa4hNfgrKdVWLwSVFU3RcjBFpm2dPbj1mozlwDc SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2015 02:14:57.7376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0433 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mika, On 12/15/15 15:55, Suravee Suthikulpanit wrote: > Add device HID AMDI0510 to match the I2C controlers on AMD Seattle platform > > Signed-off-by: Suravee Suthikulpanit > --- > drivers/i2c/busses/i2c-designware-platdrv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c > index 57f623b..a027154 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -117,6 +117,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = { > { "80860F41", 0 }, > { "808622C1", 0 }, > { "AMD0010", 0 }, > + { "AMDI0510", 0 }, > { } Since this driver seems to be used by several SOCs, and we have been adding the HID from various SOC vendors. Do you think it would be better to assign a CID so that each SOC vendor can specify in their ACPI DSDT and we can match them here? Then, we can also associate the FMCN and SSCN along with the CID, and guarantee compatibility. Thanks, Suravee > }; > MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match); >