From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934150AbbLPKg1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Dec 2015 05:36:27 -0500
Received: from mout.kundenserver.de ([212.227.17.10]:54814 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932888AbbLPKgZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Dec 2015 05:36:25 -0500
Subject: Re: [PATCH v2 3/3] ARM: bcm2835: Add the auxiliary clocks to the
 device tree.
To: Eric Anholt <eric@anholt.net>, linux-clk@vger.kernel.org
References: <1450222559-22461-1-git-send-email-eric@anholt.net>
 <1450222559-22461-3-git-send-email-eric@anholt.net>
Cc: devicetree@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Mike Turquette <mturquette@baylibre.com>, Lee Jones <lee@kernel.org>,
        Stephen Boyd <sboyd@codeaurora.org>, linux-kernel@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
From: Stefan Wahren <stefan.wahren@i2se.com>
Message-ID: <56713E74.3040907@i2se.com>
Date: Wed, 16 Dec 2015 11:35:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1450222559-22461-3-git-send-email-eric@anholt.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:4tXUatlGdWj6L4sX07GyBqyO5sxxD4NbYa1IJLaSKIJLF65dRap
 16oZWtT0kEeZ6MuOvv313Av568UJDQGrvfAv14lji4eAb8zjxwec6I3c8FGj7gh1wU/nmK1
 V/AEooII34mW7T5JLlBZllvAa2oQ1m6X0aRWEEOGNLGmwKrKnvnDFTcZ4qkbuGNbgfvu2+5
 mTPoa6i+5NlUoIRHJGC6A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:LZptcyjSXhc=:m5iYhWRxHmO5EJsVi2XUw1
 TyjLaGZzVU0z0/5n7wO/H8ZlruNDwvbPyAYHDBJHYkuks538AcR9ct62LKCRz5muPGPDhSCz8
 e3vaqLP42YAanuDr23sEVf5kKnw8+hr+o5yx9fplhxVMtfbmR/h8ZsHrY8gyP78NF0DV9G+O4
 Vv64usnceqRNXB6HTG58NYPOtLMzsVIk+8SLBTAaAwFwFsmYiSTxluR0j+qYVruwLSF3DLeeC
 9y2biSlFxdhvM2wIrV/QldarzMhopXdAOBpyf9gMH/cJxXSki4N7Dypbdixmtc0j+i1AVHqSd
 IkCHpSISQqF3yts6OLOfPFr/Veg5hUSY+XZkRtpXxlwOedPJ3d5y3+D4/RRm9xzhp95jv27sM
 JhW/YInTh1StiYmzDaMs5VmthCyiCObqESJVK5fwZCgTETpezCx6u7Wtkk/uaFCgd6rwi2pNk
 I6RwPF45quryX6ym6MQwQIReJAx/IzJHI5IXeaKJmENm51zOgt0xNxoVLo8VHOawzcD0V4IwV
 /b6JPAVXCLNLim9xkBTDqiueMJkV3W0lKdNj2Ksa8VLkj39H8eaB/wfvwQjScPqr3DxAnN0UC
 WlI8mYS1D+FdbxdCtn1tHHvI+/zBzPPhPmZfK/doEctc6eaSmztr6xQVH+clXTjT+Wfc+ith9
 X1Cm6Cb4tjh4yKsz0/p3MlR7s3Npic/NEAV97YBdvq9suulzAUAbXFkSVMQAaZ3NixacjTSwZ
 8hOwKnzfsJieEB4n
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Eric,

Am 16.12.2015 um 00:35 schrieb Eric Anholt:
> These will be used for enabling UART1, SPI1, and SPI2.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>
> v2: Make the binding cover both the IRQ and clock enable registers.
>
>  arch/arm/boot/dts/bcm2835.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> index aef64de..a27d40b 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -73,6 +73,13 @@
>  			clocks = <&clk_osc>;
>  		};
>  
> +		aux: aux@0x7e215000 {
> +			compatible = "brcm,bcm2835-aux";
> +			#clock-cells = <1>;
> +			reg = <0x7e215000 0x8>;
> +			clocks = <&clocks BCM2835_CLOCK_VPU>;
> +		};
> +

just a nit. Since the nodes should be ordered by address this should
better go between|||i2c0 and sdhci.

Thanks

Stefan

|
>  		rng@7e104000 {
>  			compatible = "brcm,bcm2835-rng";
>  			reg = <0x7e104000 0x10>;