From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755957AbbLQCQo (ORCPT ); Wed, 16 Dec 2015 21:16:44 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:55957 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbbLQCQl (ORCPT ); Wed, 16 Dec 2015 21:16:41 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f793c6d00000136c-bd-56721b042121 Content-transfer-encoding: 8BIT Message-id: <56721AFE.9020103@samsung.com> Date: Thu, 17 Dec 2015 11:16:30 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Sergei Shtylyov , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, myungjoo.ham@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-sh@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3] extcon: add Maxim MAX3355 driver References: <2473780.4IzuWX8hE2@wasted.cogentembedded.com> In-reply-to: <2473780.4IzuWX8hE2@wasted.cogentembedded.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsWyRsSkWJdVuijMYMImZov5R86xWvS/Wchq ce7VSkaLy7vmsFnM+TOF2WLRslZmi6XXLzJZ3G5cwWYxYfpaFovWvUfYLc6susXuwO2xZt4a Ro/Lfb1MHg+m/mfyWLn8C5vHplWdbB59W1YxenzeJBfAHsVlk5Kak1mWWqRvl8CVcfvxa7aC z74VzY+aWBoYD9l1MXJySAiYSNz6vIoNwhaTuHBvPZDNxSEksIJR4tmG7cwwRXe33GeESCxl lFh9cQ9YB6+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtMmrcIrFdI4AGjRMsiK4hyLYm1B6cx gtgsAqoSixumsoDYbEDx/S9usIGMERWIkOg+UQmySkSglUmie8IGJoiZ5hJzpz4Cs4UFLCSm fPnICDHfSmLlxaNgczgFrCU+d11gAmmWEGjkkPjx6AYrxDIBiW+TD4HdKSEgK7HpANRfkhIH V9xgmcAoNgvJN7MQvpmF5JsFjMyrGEVTC5ILipPSi4z0ihNzi0vz0vWS83M3MQLj9fS/Z307 GG8esD7EKMDBqMTDK7ivMEyINbGsuDL3EKMp0BETmaVEk/OBSSGvJN7Q2MzIwtTE1NjI3NJM SZw3QepnsJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQZGU6bIn7MuT7YXvrPrW3q5uKSynm2C 7Idbnp+iToYH31myrn7mjcIbdmuYDT8VZls2Z5yfnvrA65/ugRCugl4+rtguwdsPZTK4pf/1 Nc+tNjs488raV5FHm2LmiVR5hJ/M1M9UzJaLL+OY81kkNH575sezhz1vJvHbLhVovqr5Ya9S R+IJ/+lKLMUZiYZazEXFiQArdoqR0gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42I5/e+xgC6LdFGYwc1Flhbzj5xjteh/s5DV 4tyrlYwWl3fNYbOY82cKs8WiZa3MFkuvX2SyuN24gs1iwvS1LBate4+wW5xZdYvdgdtjzbw1 jB6X+3qZPB5M/c/ksXL5FzaPTas62Tz6tqxi9Pi8SS6APaqB0SYjNTEltUghNS85PyUzL91W yTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6EolhbLEnFKgUEBicbGSvh2mCaEhbroW MI0Rur4hQXA9RgZoIGENY8btx6/ZCj77VjQ/amJpYDxk18XIySEhYCJxd8t9RghbTOLCvfVs XYxcHEICSxklVl/cwwaS4BUQlPgx+R5LFyMHB7OAvMSRS9kgYWYBdYlJ8xYxg9hCAg8YJVoW WUGUa0msPTgNbCaLgKrE4oapLCA2G1B8/4sbbCBjRAUiJLpPVIKsEhFoZZLonrCBCWKmucTc qY/AbGEBC4kpXz4yQsy3klh58SjYHE4Ba4nPXReYJjAKzEJy3SyE62YhuW4BI/MqRonUguSC 4qT0XMO81HK94sTc4tK8dL3k/NxNjOCU8ExqB+PBXe6HGAU4GJV4eAX2FYYJsSaWFVfmHmKU 4GBWEuH9vgcoxJuSWFmVWpQfX1Sak1p8iNEU6L+JzFKiyfnAdJVXEm9obGJmZGlkbmhhZGyu JM5beykyTEggPbEkNTs1tSC1CKaPiYNTqoGx8UDXzpoJ1qu35qZ9lWy7VWRx9keclHTUhIsq oQXGUz5O/3zrSscRycqb315P71y1z27jn5NXZA/VnH+uas6fWr9g2SJtm70HG5uWRWefUwve 7hLeFBq24tgzpoiGC1ne7HsX32Jz9FzzZG7k2oW1y2MljF92rmdzW2r0gu3YtSmVs/ZLl0Ra KLEUZyQaajEXFScCAASosv8fAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sergei, On 2015년 12월 17일 03:07, Sergei Shtylyov wrote: > Maxim Integrated MAX3355E chip integrates a charge pump and comparators to > enable a system with an integrated USB OTG dual-role transceiver to > function as an USB OTG dual-role device. In addition to sensing/controlling > Vbus, the chip also passes thru the ID signal from the USB OTG connector. > On some Renesas boards, this signal is just fed into the SoC thru a GPIO > pin -- there's no real OTG controller, only host and gadget USB controllers > sharing the same USB bus; however, we'd like to allow host or gadget > drivers to be loaded depending on the cable type, hence the need for the > MAX3355 extcon driver. The Vbus status signals are also wired to GPIOs > (however, we aren't currently interested in them), the OFFVBUS# signal is > controlled by the host controllers, there's also the SHDN# signal wired to > a GPIO, it should be driven high for the normal operation. > > Signed-off-by: Sergei Shtylyov > > --- > Changes in version 3: > - reformatted the change log. > > Changes in version 2: > - added the USB gadget cable support; > - added the remove() driver method which drives SHDN# GPIO low to save power; > - dropped vendor prefix from the ID GPIO property name; > - changed the GPIO property name suffix to "-gpios"; > - switched to usign extcon_set_cable_state_() API; > - switched to using the gpiod/sleeping 'gpiolib' APIs; > - addded error messages to max3355_probe(); > - added IRQF_NO_SUSPEND flasg to the devm_request_threaded_irq() call; > - renamed 'ret' variable to 'err' in max3355_probe(); > - expanded the Kconfig entry help text; > - added vendor name to the patch summary, the bindings document, the Kconfig > entry, the driver heading comment, the module description, and the change log; > - fixed up and reformatted the change log. > > Documentation/devicetree/bindings/extcon/extcon-max3355.txt | 21 + > drivers/extcon/Kconfig | 8 > drivers/extcon/Makefile | 1 > drivers/extcon/extcon-max3355.c | 153 ++++++++++++ > 4 files changed, 183 insertions(+) > > Index: renesas/Documentation/devicetree/bindings/extcon/extcon-max3355.txt > =================================================================== > --- /dev/null > +++ renesas/Documentation/devicetree/bindings/extcon/extcon-max3355.txt > @@ -0,0 +1,21 @@ > +Maxim Integrated MAX3355 USB OTG chip > +------------------------------------- > + > +MAX3355 integrates a charge pump and comparators to enable a system with an > +integrated USB OTG dual-role transceiver to function as a USB OTG dual-role > +device. > + > +Required properties: > +- compatible: should be "maxim,max3355"; > +- maxim,shdn-gpios: should contain a phandle and GPIO specifier for the GPIO pin > + connected to the MAX3355's SHDN# pin; > +- id-gpios: should contain a phandle and GPIO specifier for the GPIO pin > + connected to the MAX3355's ID_OUT pin. > + > +Example (Koelsch board): > + > + usb-otg { > + compatible = "maxim,max3355"; > + maxim,shdn-gpios = <&gpio2 4 GPIO_ACTIVE_LOW>; > + id-gpios = <&gpio5 31 GPIO_ACTIVE_HIGH>; > + }; > Index: renesas/drivers/extcon/Kconfig > =================================================================== > --- renesas.orig/drivers/extcon/Kconfig > +++ renesas/drivers/extcon/Kconfig > @@ -52,6 +52,14 @@ config EXTCON_MAX14577 > Maxim MAX14577/77836. The MAX14577/77836 MUIC is a USB port accessory > detector and switch. > > +config EXTCON_MAX3355 > + tristate "Maxim MAX3355 USB OTG EXTCON Support" > + help > + If you say yes here you get support for the USB OTG role detection by > + MAX3355. The MAX3355 chip integrates a charge pump and comparators to > + enable a system with an integrated USB OTG dual-role transceiver to > + function as an USB OTG dual-role device. > + > config EXTCON_MAX77693 > tristate "Maxim MAX77693 EXTCON Support" > depends on MFD_MAX77693 && INPUT > Index: renesas/drivers/extcon/Makefile > =================================================================== > --- renesas.orig/drivers/extcon/Makefile > +++ renesas/drivers/extcon/Makefile > @@ -8,6 +8,7 @@ obj-$(CONFIG_EXTCON_ARIZONA) += extcon-a > obj-$(CONFIG_EXTCON_AXP288) += extcon-axp288.o > obj-$(CONFIG_EXTCON_GPIO) += extcon-gpio.o > obj-$(CONFIG_EXTCON_MAX14577) += extcon-max14577.o > +obj-$(CONFIG_EXTCON_MAX3355) += extcon-max3355.o > obj-$(CONFIG_EXTCON_MAX77693) += extcon-max77693.o > obj-$(CONFIG_EXTCON_MAX77843) += extcon-max77843.o > obj-$(CONFIG_EXTCON_MAX8997) += extcon-max8997.o > Index: renesas/drivers/extcon/extcon-max3355.c > =================================================================== > --- /dev/null > +++ renesas/drivers/extcon/extcon-max3355.c > @@ -0,0 +1,153 @@ > +/* > + * Maxim Integrated MAX3355 USB OTG chip extcon driver > + * > + * Copyright (C) 2014 Cogent Embedded, Inc. 2014 -> 2015 > + * Author: Sergei Shtylyov > + * > + * This software is licensed under the terms of the GNU General Public > + * License version 2, as published by the Free Software Foundation, and > + * may be copied, distributed, and modified under those terms. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +struct max3355_data { > + struct extcon_dev *edev; > + struct gpio_desc *id_gpiod; > + struct gpio_desc *shdn_gpiod; > +}; > + > +static const unsigned int max3355_cable[] = { > + EXTCON_USB, > + EXTCON_USB_HOST, > + EXTCON_NONE, > +}; > + > +static irqreturn_t max3355_id_irq(int irq, void *dev_id) > +{ > + struct max3355_data *data = dev_id; > + int id = gpiod_get_value_cansleep(data->id_gpiod); > + > + if (id) { > + /* > + * ID = 1 means USB HOST cable detached. > + * As we don't have event for USB peripheral cable attached, > + * we simulate USB peripheral attach here. > + */ > + extcon_set_cable_state_(data->edev, EXTCON_USB_HOST, false); > + extcon_set_cable_state_(data->edev, EXTCON_USB, true); > + } else { > + /* > + * ID = 0 means USB HOST cable attached. > + * As we don't have event for USB peripheral cable detached, > + * we simulate USB peripheral detach here. > + */ > + extcon_set_cable_state_(data->edev, EXTCON_USB, false); > + extcon_set_cable_state_(data->edev, EXTCON_USB_HOST, true); > + } > + > + return IRQ_HANDLED; > +} > + > +static int max3355_probe(struct platform_device *pdev) > +{ > + struct device_node *np = pdev->dev.of_node; > + struct max3355_data *data; > + struct gpio_desc *gpiod; > + int irq, err; > + > + data = devm_kzalloc(&pdev->dev, sizeof(struct max3355_data), > + GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + data->edev = devm_extcon_dev_allocate(&pdev->dev, max3355_cable); > + if (IS_ERR(data->edev)) { > + dev_err(&pdev->dev, "failed to allocate extcon device\n"); > + return PTR_ERR(data->edev); > + } > + data->edev->name = kstrdup(np->name, GFP_KERNEL); You don't need to set the name of extcon device. Instead, the extcon_dev_register() will set it. > + > + gpiod = devm_gpiod_get(&pdev->dev, "id", GPIOD_IN); > + if (IS_ERR(gpiod)) { > + dev_err(&pdev->dev, "failed to get ID_OUT GPIO\n"); > + return PTR_ERR(gpiod); > + } > + data->id_gpiod = gpiod; > + > + gpiod = devm_gpiod_get(&pdev->dev, "maxim,shdn", GPIOD_OUT_HIGH); > + if (IS_ERR(gpiod)) { > + dev_err(&pdev->dev, "failed to get SHDN# GPIO\n"); > + return PTR_ERR(gpiod); > + } > + data->shdn_gpiod = gpiod; > + > + err = devm_extcon_dev_register(&pdev->dev, data->edev); > + if (err < 0) { > + dev_err(&pdev->dev, "failed to register extcon device\n"); > + return err; > + } > + > + irq = gpiod_to_irq(data->id_gpiod); > + if (irq < 0) { > + dev_err(&pdev->dev, "failed to translate ID_OUT GPIO to IRQ\n"); > + return irq; > + } > + > + err = devm_request_threaded_irq(&pdev->dev, irq, NULL, max3355_id_irq, > + IRQF_ONESHOT | IRQF_NO_SUSPEND | > + IRQF_TRIGGER_RISING | > + IRQF_TRIGGER_FALLING, > + pdev->name, data); > + if (err < 0) { > + dev_err(&pdev->dev, "failed to request ID_OUT IRQ\n"); > + return err; > + } I recommend that you reorder the init code in probe() as following: 1. Allocate the memory of max3355_data *data. 2. Parse and initialize the gpio (id, shdn) 3. Allocate the memory of extcon_dev and register it. 4. Request the interrupt. > + > + platform_set_drvdata(pdev, data); > + > + /* Perform initial detection */ > + max3355_id_irq(irq, data); > + > + return 0; > +} > + > +static int max3355_remove(struct platform_device *pdev) > +{ > + struct max3355_data *data = platform_get_drvdata(pdev); > + > + gpiod_set_value_cansleep(data->shdn_gpiod, 0); > + > + return 0; > +} > + > +static const struct of_device_id max3355_match_table[] = { > + { .compatible = "maxim,max3355", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, max3355_match_table); > + > +static struct platform_driver max3355_driver = { > + .probe = max3355_probe, > + .remove = max3355_remove, > + .driver = { > + .name = "extcon-max3355", > + .of_match_table = max3355_match_table, > + .owner = THIS_MODULE, You don't need to add the 'owner'. > + }, > +}; > + > +module_platform_driver(max3355_driver); > + > +MODULE_AUTHOR("Sergei Shtylyov "); > +MODULE_DESCRIPTION("Maxim MAX3355 extcon driver"); > +MODULE_LICENSE("GPL v2"); Thanks, Chanwoo Choi